chore(documents-v2): Catch error and log warning #16207
Conversation
WalkthroughThe changes in this pull request focus on enhancing the error handling and default value management within the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- libs/api/domains/documents/src/lib/documentV2.service.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/api/domains/documents/src/lib/documentV2.service.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16207 +/- ##
=======================================
Coverage 36.69% 36.69%
=======================================
Files 6778 6778
Lines 139671 139671
Branches 39719 39719
=======================================
Hits 51247 51247
Misses 88424 88424 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 34 Total Test Services: 0 Failed, 33 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
* Catch error and log warning * Update libs/api/domains/documents/src/lib/documentV2.service.ts Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> --------- Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Catch error
/pageand log warning.Why
Too many errors.
An error here is expected in some cases. It indicates a user error. Return the default of
1which in most cases would be the number from the service.Checklist:
Summary by CodeRabbit
1is returned in case of an error.getPageNumbermethod to prevent failures during document retrieval.