fix(web): Pension Calculator - Different max month pension delay if year <= 1951

[RunarVestmann]

Pension Calculator - Different max month pension delay if year <= 1951

Why

• This change was requested by the social insurance administration

Screenshots / Gifs

Before

If birthyear <= 1951 then user can select up to a 156 month delay

After

If birthyear <= 1951 then user can no longer select an option more than 60 months in advance

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced pension delay calculations based on the individual's birth year, allowing for more accurate pension outcomes.

• Bug Fixes

  • Updated logic to ensure correct pension delay calculations when the birth year changes.

[coderabbitai]

Walkthrough

The changes in the PensionCalculator.tsx file involve a refined approach to calculating pension delays based on an individual's birth year. The previous single variable for maximum pension delay has been replaced with two distinct variables, allowing for differentiated calculations. Additionally, the dependency array for the useEffect hook has been updated to include birthYear, ensuring accurate recalculations when the birth year changes.

Changes

File	Change Summary
apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx	Introduced two new variables for pension delay based on birth year; updated logic to utilize these variables and modified useEffect dependency.

Possibly related PRs

• fix(web): Pension calculator toggled off #15951: Modifies PensionCalculator.tsx and introduces a new constant affecting the rendering logic of the pension calculator interface.
• feat(web): Pension Calculator - Tax calculation translation #16033: Adds a new translation string in translationStrings.ts, relevant to the pension calculator feature, enhancing localization support.
• fix(web): Pension Calculator - Remove space in translation string keys #16037: Makes formatting changes in translationStrings.ts, ensuring translation keys are clean and consistent.

Suggested labels

high priority

Suggested reviewers

• mannipje

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 378e8a9 and 26c20a4.

Files selected for processing (1)

• apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (3 hunks)

Additional context used

Path-based instructions (1)

apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

Additional comments not posted (3)

apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (3)

136-140: Appropriate addition of birth year-dependent maximum pension delay constants

The introduction of maxMonthPensionDelayIfBornAfter1951 and maxMonthPensionDelayIfBorn1951OrEarlier with default values of 156 and 60 respectively correctly accommodates the new requirement to handle different maximum pension delays based on the user's birth year.

---

393-397: Correct implementation of conditional maxMonthPensionDelay calculation

The conditional logic assigning maxMonthPensionDelay based on whether birthYear is less than 1952 accurately reflects the specified business rules. This ensures users born in or before 1951 receive the appropriate maximum pension delay.

---

411-417: Updated dependency array to include new variables ensures proper reactivity

Adding birthYear, maxMonthPensionDelayIfBorn1951OrEarlier, and maxMonthPensionDelayIfBornAfter1951 to the dependency array of the useMemo hook ensures that startYearOptions are recalculated whenever these values change, preventing potential bugs related to stale state.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for code reviews. This model has advanced reasoning capabilities and can provide more nuanced feedback on your code.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• • Please join our Discord Community to provide feedback and report issues on the discussion post.

[datadog-island-is]

Datadog Report

Branch report: fix/web-pension-calculator-max-pension-delay
Commit report: cf86ecb
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 33.44s Total Time
➡️ Test Sessions change in coverage: 1 no change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.75%. Comparing base (378e8a9) to head (26c20a4).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16052   +/-   ##
=======================================
  Coverage   36.75%   36.75%           
=======================================
  Files        6733     6733           
  Lines      138138   138137    -1     
  Branches    39252    39251    -1     
=======================================
  Hits        50774    50774           
+ Misses      87364    87363    -1     

Files with missing lines	Coverage Δ
...ocialInsuranceAdministration/PensionCalculator.tsx	0.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378e8a9...26c20a4. Read the comment docs.