fix(web): Pension Calculator - Limit how far into future start month can be

[RunarVestmann]

Pension Calculator - Limit how far into future start month can be

Before

Max is 60 months but users can select more because all possible months are an option

Screen.Recording.2024-09-19.at.16.14.37.mov

After

Screen.Recording.2024-09-19.at.16.16.53.mov

Summary by CodeRabbit

Summary by CodeRabbit

• New Features
  • Enhanced month filtering logic in the Pension Calculator based on user input for birth year and selected start year, ensuring relevant month options are displayed.
  • Improved handling of month selection for a more streamlined user experience.

[coderabbitai]

Walkthrough

The changes in the PensionCalculator.tsx file enhance the logic for determining valid month options based on the user's birth year, selected start year, and a new defaultPensionDate. The updates ensure that the calculation for maxMonthPensionDelay is appropriately positioned, and the logic now accounts for the presence of defaultPensionDate, returning relevant month options based on user input.

Changes

File	Change Summary
apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx	Enhanced logic for valid month options based on user birth year and selected start year, including checks for defaultPensionDate and streamlined month selection handling.

Possibly related PRs

• fix(web): Pension calculator toggled off #15951: Modifies the PensionCalculator.tsx file to enhance functionality related to pension calculation forms.
• fix(web): Pension Calculator - Different max month pension delay if year <= 1951 #16052: Introduces changes to handle pension delay based on birth year, relevant to month filtering logic.
• feat(web): Pension Calculator - Tax calculation translation #16033: Adds a new translation string in translationStrings.ts, related to the pension calculator.
• fix(web): Pension calculator translation changes #16070: Addresses missing translations in translationStrings.ts for the pension calculator, connecting to localization aspects.

Suggested reviewers

• mannipje

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e9ebcaf and 084e786.

Files selected for processing (1)

• apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (1 hunks)

Additional context used

Path-based instructions (1)

apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

Additional comments not posted (1)

apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculator.tsx (1)

435-445: Avoid updating form values directly.

Updating the startMonth value directly using methods.setValue bypasses form validation. Consider letting the form handle the value update to ensure proper validation.

Remove the direct value update:

if (
  startYear === startYearOptions?.[0]?.value && 
  typeof birthMonth === 'number' &&
  typeof startMonth === 'number'  
) {
- if (startMonth < birthMonth + 1) {
-   methods.setValue('startMonth', birthMonth + 1)
- }
  return monthOptions.filter(({ value }) => value >= birthMonth + 1)
}

Likely invalid or redundant comment.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 36.65%. Comparing base (7978416) to head (cd6a3c6).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ocialInsuranceAdministration/PensionCalculator.tsx	0.00%	30 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16094   +/-   ##
=======================================
  Coverage   36.65%   36.65%           
=======================================
  Files        6749     6749           
  Lines      138752   138752           
  Branches    39416    39416           
=======================================
  Hits        50863    50863           
  Misses      87889    87889           

Flag	Coverage Δ
web	1.84% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ocialInsuranceAdministration/PensionCalculator.tsx	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da112ed...cd6a3c6. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: fix/web-pension-calculator-start-month-options
Commit report: a5ba79e
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 31.83s Total Time
➡️ Test Sessions change in coverage: 1 no change