feat(web): Pension calculator - "Breyta forsendum" button visual changes #16373
Conversation
RunarVestmann
added
the
deprecated:automerge
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculatorResults.tsx (1)
281-283: LGTM with a minor typo: changeAssumtionsHref implementationThe
changeAssumtionsHrefconstant is well-implemented, using the linkResolver for consistent routing and appending the queryParamString to preserve the form state. This aligns with the PR objectives.However, there's a minor typo in the variable name:
-const changeAssumtionsHref = `${ +const changeAssumptionsHref = `${ linkResolver('pensioncalculator').href }?${queryParamString}`
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- apps/web/components/LanguageToggler/LanguageToggler.tsx (1 hunks)
- apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculatorResults.tsx (7 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/web/components/LanguageToggler/LanguageToggler.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculatorResults.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (4)
apps/web/screens/Organization/SocialInsuranceAdministration/PensionCalculatorResults.tsx (4)
62-71: LGTM: New ChangeAssumptionsButton component looks goodThe new
ChangeAssumptionsButtoncomponent is well-implemented. It follows React best practices, uses TypeScript for type safety, and aligns with the PR objectives by using a text variant button with an arrow back icon. The component is reusable and adheres to the single responsibility principle.
336-345: LGTM: Well-implemented ChangeAssumptionsButton placementThe placement of the
ChangeAssumptionsButtonwithin aHiddencomponent is well-implemented. It manages visibility based on print settings and uses responsive design practices with thejustifyContentprop. This implementation aligns with the PR objectives for enhancing the visual design of the "Breyta forsendum" button.
392-394: LGTM: Appropriate placement of ChangeAssumptionsButton in detailed viewThe
ChangeAssumptionsButtonis well-placed within the detailed view, wrapped in aHiddencomponent for print-only visibility. This ensures the button is available in the appropriate context and follows good practices for managing different output formats.
507-510: LGTM: Effective implementation of language toggle query paramsThe addition of
languageToggleQueryParamsis well-implemented. It correctly preserves the query parameters for both 'is' and 'en' languages, ensuring that users can switch between locales without losing their current form state. This aligns perfectly with the PR objectives.
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 33.39s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16373 +/- ##
==========================================
- Coverage 36.75% 36.75% -0.01%
==========================================
Files 6804 6804
Lines 140903 140909 +6
Branches 40137 40137
==========================================
Hits 51785 51785
- Misses 89118 89124 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Pension calculator - "Breyta forsendum" button visual changes
What
Screenshots / Gifs
Before
Screen.Recording.2024-10-11.at.14.53.02.mov
After
Screen.Recording.2024-10-11.at.14.52.32.mov
Checklist:
Summary by CodeRabbit
New Features
ChangeAssumptionsButtonfor easier navigation within the Pension Calculator results.Improvements