feat(web): Add default header for rikissaksoknari organization #16095
Conversation
WalkthroughThe changes introduce new CSS styles for the "rikissaksoknari" component, enhancing its layout and visual properties. Additionally, the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1)
73-106: Looks good! Consider monitoring performance.The code segment follows the existing pattern of defining base styles and extending them with additional responsive styles. The grid layout dimensions and background styles seem appropriate for the "rikissaksoknari" organization. The code adheres to the NextJS best practices for CSS modules and responsive design.
One minor suggestion: The complex linear gradient background might impact performance. Consider monitoring the performance impact and optimize if necessary. However, given the limited scope of usage, it's not a major concern.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (2 hunks)
- apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1 hunks)
Additional context used
Path-based instructions (2)
apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/web/components/Organization/Wrapper/OrganizationWrapper.css.ts (1)
Line range hint
60-71: LGTM!The code segment follows the existing pattern of extending base styles with additional responsive styles. The background image URL and size seem appropriate for the
lgbreakpoint. The code adheres to the NextJS best practices for CSS modules and responsive design.apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (1)
519-528: Conditional rendering logic for 'rikissaksoknari' theme header looks good!The changes introduce a new condition to render the
DefaultHeadercomponent for the 'rikissaksoknari' theme whenn('usingDefaultHeader', false)is true. This allows for a configurable header where theDefaultHeadercan be used instead of theRikissaksoknariHeaderbased on theusingDefaultHeadernamespace value.The
DefaultHeadercomponent receives props spread fromdefaultPropsand an additionalclassNameprop that dynamically sets the class name based onisSubpage. This ensures that the appropriate styling is applied to the header.If the condition is false, it falls back to rendering the
RikissaksoknariHeadercomponent as before, maintaining backwards compatibility.
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16095 +/- ##
=======================================
Coverage 36.65% 36.66%
=======================================
Files 6749 6749
Lines 138748 138735 -13
Branches 39412 39410 -2
=======================================
Hits 50863 50863
+ Misses 87885 87872 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kodiakhq
bot
deleted the
feature/add-default-header-for-rikissaksoknara
branch
Add default header for rikissaksoknari organization
What
Make it possible to use default header for Ríkissaksóknari organization via config.
Why
A design that was approved by Digital Iceland
Screenshots / Gifs
Before
After
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes