Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Add default header for HMS organization #16028

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

mannipje
Copy link
Member

@mannipje mannipje commented Sep 17, 2024

Add default header for HMS organization

What

Make it possible to use default header for HMS organization via config.

Why

A design that was approved by Digital Iceland

Screenshots / Gifs

Before

image

After

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Enhanced theme configuration logic to support additional header conditions.
    • Improved rendering flexibility for the OrganizationHeader based on header type.

@mannipje mannipje added the automerge Merge this PR as soon as all checks pass label Sep 17, 2024
@mannipje mannipje requested a review from a team as a code owner September 17, 2024 10:44
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

The changes involve modifications to the getThemeConfig function and the OrganizationHeader component. The conditional logic in getThemeConfig now prioritizes checks for lightThemes and usingDefaultHeader, leading to a more streamlined flow. In the OrganizationHeader, the rendering logic has been updated to conditionally render either a DefaultHeader or an HmsHeader based on the value of usingDefaultHeader. These adjustments refine the control flow for theme and header rendering.

Changes

Files Change Summary
apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx Adjusted getThemeConfig to prioritize usingDefaultHeader in theme selection; updated OrganizationHeader to conditionally render headers based on usingDefaultHeader.

Possibly related PRs

Suggested labels

high priority


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a9e0d62 and 662fd20.

Files selected for processing (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/components/Organization/Wrapper/OrganizationWrapper.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for generating code suggestions in code reviews.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.76%. Comparing base (323fd56) to head (662fd20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16028      +/-   ##
==========================================
+ Coverage   36.75%   36.76%   +0.01%     
==========================================
  Files        6733     6733              
  Lines      138139   138099      -40     
  Branches    39252    39247       -5     
==========================================
+ Hits        50774    50775       +1     
+ Misses      87365    87324      -41     
Flag Coverage Δ
web 1.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nents/Organization/Wrapper/OrganizationWrapper.tsx 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323fd56...662fd20. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 17, 2024

Datadog Report

Branch report: feature/add-default-header-for-hms
Commit report: 77ec52a
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 31.57s Total Time
➡️ Test Sessions change in coverage: 1 no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants