fix(signature-collection): Not stop paper signatures when already signed #16137
Conversation
WalkthroughThe Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts (1 hunks)
Additional context used
Path-based instructions (1)
libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (2)
libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts (2)
151-154: Confirm the necessity of passingsigneeNationalIdalongsideuserThe
getSigneemethod is called with bothuserandinput.signeeNationalId:const signee = await this.signatureCollectionClientService.getSignee( user, input.signeeNationalId, )Please verify if it's necessary to pass
input.signeeNationalIdwhen theuserobject may already contain the national ID. If they can differ (e.g., signing on behalf of another signee), consider adding documentation or comments to clarify this behavior to maintain consistency and prevent confusion.
156-161: Ensure safe access tosignee.canSignInfoIn the computation of
canSign:const canSign = signee.canSign || (signee.canSignInfo?.length === 1 && signee.canSignInfo[0] === ReasonKey.AlreadySigned)Confirm that
signee.canSignInfois reliably defined whensignee.canSignisfalse. While optional chaining (?.) helps prevent runtime errors, it's important to ensure thatsignee.canSignInfoinitializes as an array orundefinedbut notnull. This verification will help avoid potential issues ifsignee.canSignInfois unexpectedlynull.
libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts
Show resolved
Hide resolved
libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts
Show resolved
Hide resolved
juni-haukur
added
the
deprecated:automerge
Datadog ReportBranch report: ✅ 0 Failed, 4 Passed, 0 Skipped, 2.9s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16137 +/- ##
=======================================
Coverage 36.69% 36.69%
=======================================
Files 6761 6761
Lines 139064 139064
Branches 39497 39497
=======================================
Hits 51035 51035
Misses 88029 88029
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes