fix(signature-colletion): allow manager on paper upload #16427
Conversation
WalkthroughThe changes in this pull request focus on modifying the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
albinagu
changed the title
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
libs/api/domains/signature-collection/src/lib/signatureCollection.resolver.ts (1)
183-183: LGTM! Consider adding a comment for clarity.The addition of
@AllowManager()successfully implements the PR objective. This change allows managers to upload paper signatures as intended.Consider adding a brief comment explaining the rationale behind allowing managers to perform this action, for improved code maintainability. For example:
// Allow managers to upload paper signatures as per business requirements @AllowManager()
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- libs/api/domains/signature-collection/src/lib/signatureCollection.resolver.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/api/domains/signature-collection/src/lib/signatureCollection.resolver.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/signature-collection/src/lib/signatureCollection.resolver.ts
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16427 +/- ##
=======================================
Coverage 36.72% 36.73%
=======================================
Files 6809 6809
Lines 141165 141131 -34
Branches 40245 40228 -17
=======================================
- Hits 51844 51839 -5
+ Misses 89321 89292 -29
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* fix: allow manager on paper upload * fix: rm cl * fix: rm cl * chore: nx format:write update dirty files --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
) * fix: allow manager on paper upload * fix: rm cl * fix: rm cl * chore: nx format:write update dirty files --------- Co-authored-by: Alex Diljar Birkisbur Hellsing <42963845+alexdiljar@users.noreply.github.com> Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Allow manager to upload paper signatures
Why
It is their right
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
@AllowManager()decorator.Bug Fixes