fix(j-s): Remove required criminal record upload in indictments

[unakb]

Taka út stjörnumerkingu hjá sakavottorði

What

Remove criminal record requirement from indictment cases

Why

Some cases don't require a criminal record, and some people don't have criminal records to upload

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Simplified validation logic for file uploads in the Case Files section, making it easier for users to proceed without mandatory criminal record files.

• Bug Fixes

  • Adjusted validation conditions to streamline the process for determining the validity of case files, enhancing user experience.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the validation logic for file uploads in the CaseFiles.tsx component and the isCaseFilesStepValidIndictments function in validate.ts. The requirement for a CRIMINAL_RECORD file to be present for validation has been removed, simplifying the conditions for determining if the step is valid. Additionally, UI elements related to file categories have been adjusted, but the overall file upload functionalities and component structure remain consistent.

Changes

File Path	Change Summary
apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx	Modified validation logic for file uploads by removing the requirement for a CRIMINAL_RECORD file; adjusted UI elements for file categories.
apps/judicial-system/web/src/utils/validate.ts	Simplified the isCaseFilesStepValidIndictments function by removing checks for CRIMINAL_RECORD and altering conditions for traffic violations and indictments.

Possibly related PRs

• chore(j-s): Criminal record update visible in in indictments case lists #15099: The changes in IndictmentCaseFilesList.tsx involve filtering for CRIMINAL_RECORD_UPDATE files, which relates to the modifications in the main PR that simplify validation logic for file uploads, including criminal records.
• fix(j-s): Required Uploads #15290: The changes in Conclusion.tsx involve adjustments to the logic for handling case data, which may relate to the overall validation and handling of case files in the main PR.
• fix(j-s): Memoize CaseFiles so they don't move when renaming  #16149: The changes in CaseFile.tsx involve optimizing the filtering of case files based on categories, which aligns with the main PR's focus on modifying validation logic for file uploads.
• fix(j-s): Filter Case Files by Police Case Number #16422: The changes in CaseFile.tsx introduce a filtering mechanism for case files by police case number, which is relevant to the main PR's focus on file management and validation logic.

Suggested labels

automerge

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.78%. Comparing base (7a1aab1) to head (eb73c61).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16563      +/-   ##
==========================================
- Coverage   36.80%   36.78%   -0.02%     
==========================================
  Files        6854     6854              
  Lines      142261   142229      -32     
  Branches    40576    40564      -12     
==========================================
- Hits        52353    52322      -31     
+ Misses      89908    89907       -1     

Flag	Coverage Δ
judicial-system-web	27.73% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...tes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx	0.00% <ø> (ø)
apps/judicial-system/web/src/utils/validate.ts	40.69% <100.00%> (+0.31%)	⬆️

... and 12 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce4547...eb73c61. Read the comment docs.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4f5bc17 and 54b9e38.

📒 Files selected for processing (2)

• apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx (0 hunks)
• apps/judicial-system/web/src/utils/validate.ts (1 hunks)

💤 Files with no reviewable changes (1)

• apps/judicial-system/web/src/routes/Prosecutor/Indictments/CaseFiles/CaseFiles.tsx

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/utils/validate.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

[datadog-island-is]

Datadog Report

Branch report: j-s/remove-required-criminal-record
Commit report: 0f83b4b
Test service: judicial-system-web

✅ 0 Failed, 338 Passed, 0 Skipped, 1m 10.72s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.01%)