Unicorn pipe #17094
Merged
Unicorn pipe #17094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/unicorn-app #17094 +/- ##
=======================================================
+ Coverage 35.53% 35.58% +0.04%
=======================================================
Files 6926 6937 +11
Lines 146908 147239 +331
Branches 41920 41972 +52
=======================================================
+ Hits 52208 52398 +190
- Misses 94700 94841 +141 Flags with carried forward coverage won't be shown. Click here to find out more. see 91 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
busla
requested changes
Dec 2, 2024
.github/workflows/unicorns.yml
Outdated
| - name: Check unicorn affected | ||
| id: unicorn-affected | ||
| run: | | ||
| yarn nx show projects --base origin/main --affected |
There was a problem hiding this comment.
Suggested change
| yarn nx show projects --base origin/main --affected | |
| yarn nx show projects --base ${{ github.event.repository.default_branch }} --affected |
There was a problem hiding this comment.
Yes, eventually - Though I'd keep it here since next step is also something we need to develop in a controlled environment
Datadog ReportAll test runs ✅ 99 Total Test Services: 0 Failed, 91 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (22)
|
Co-authored-by: Jón Levy <levy@andes.is>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
robertaandersen
added a commit
that referenced
this pull request
Dec 20, 2024
* feat: cd test app * fix: rename app * fix: name * fix: added dummy queries and codegen target * fix: eslint * fix: style * fix: import query * fix: import shared type * fix: affect shared/types * fix: add docker-next target * fix: nx project and infra * chore: eslint * chore: eslint * chore: remove jsx-a11y * fix: ignore css * chore: nx format:write update dirty files * Chore: adding unicorn to uber chart * fix: support values file per service * fix: cleanup * fix: added values per service * fix: only a single service please * fix: set service toplevel * fix: format * fix: use yaml not js-yaml * fix: remove release-tag arg * fix: console message * chore: remove helm values refactor * chore: remove helm values * chore: yarn charts * chore: charts update dirty files * chore: nx format:write update dirty files * chore: charts update dirty files * fix: make unaffected * Unicorn pipe (#17094) * chore: Adding pipeline for unicorns * unicorn pipe * unicorn pipe * unicorn pipe * unicorn pipe * pipetest * pipetest * pipetest * chore: nx format:write update dirty files * Update .github/workflows/unicorns.yml Co-authored-by: Jón Levy <levy@andes.is> * suggestions * chore: nx format:write update dirty files * unicorn pipe * suggestions --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: Jón Levy <levy@andes.is> * chore: charts update dirty files * chore: Adding pipeline to detect unicorns (#17165) * chore: Adding tests if pipeline should run on unicorns * chore: nx format:write update dirty files * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: find release branch * chore: nx format:write update dirty files * chore: find release branch * chore: find release branch * cleanup * branch sync * mergequeue * chore: testing pipeline * chore: nx format:write update dirty files * ignore * ignore * ignore * testing pipeline * testing pipeline * testing pipeline --------- Co-authored-by: andes-it <builders@andes.is> * chore: nx format:write update dirty files * chore: testing mergequeue * Adding mergequeue ci * chore: testing mergequeue * chore: testing mergequeue * Uni pr (#17280) * chore: testing mergequeue * Adding mergequeue ci * chore: testing mergequeue * chore: testing mergequeue * chore: testing mergequeue * chore: testing mergequeue * chore: nx format:write update dirty files * chore: nx format:write update dirty files * chore: testing mergequeue * chore: testing mergequeue * Uni pr (#17280) * chore: testing mergequeue * Adding mergequeue ci * chore: testing mergequeue * chore: testing mergequeue * chore: testing mergequeue --------- Co-authored-by: Jón Levy <levy@andes.is> Co-authored-by: andes-it <builders@andes.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist: