Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding pipeline to detect unicorns #17165

Merged
merged 33 commits into from
Dec 18, 2024

Conversation

robertaandersen
Copy link
Member

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@robertaandersen robertaandersen requested review from a team as code owners December 6, 2024 15:13
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@brynjarorng brynjarorng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ISH?

@robertaandersen robertaandersen removed the request for review from a team December 6, 2024 15:48
@robertaandersen robertaandersen changed the title Unicorn pipe rel3 chore: Adding pipeline to detect unicorns Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature/unicorn-app@e3f87ba). Learn more about missing BASE report.

Files with missing lines Patch % Lines
apps/unicorn-app/src/app/api/hello/route.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             feature/unicorn-app   #17165   +/-   ##
======================================================
  Coverage                       ?   35.58%           
======================================================
  Files                          ?     6937           
  Lines                          ?   147239           
  Branches                       ?    41972           
======================================================
  Hits                           ?    52400           
  Misses                         ?    94839           
  Partials                       ?        0           
Flag Coverage Δ
unicorn-app 25.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/unicorn-app/src/app/api/hello/route.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f87ba...7f28aa8. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Dec 6, 2024

Datadog Report

All test runs 62aa1f6 🔗

98 Total Test Services: 0 Failed, 90 Passed
🔻 Test Sessions change in coverage: 3 decreased, 2 increased, 194 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 63 0 22.23s N/A Link
air-discount-scheme-web 0 0 0 2 0 6.44s N/A Link
api 0 0 0 4 0 2.39s N/A Link
api-catalogue-services 0 0 0 23 0 8.98s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 17.17s N/A Link
api-domains-assets 0 0 0 3 0 9.54s N/A Link
api-domains-auth-admin 0 0 0 18 0 10.11s N/A Link
api-domains-communications 0 0 0 5 0 31.27s N/A Link
api-domains-criminal-record 0 0 0 5 0 8.64s N/A Link
api-domains-driving-license 0 0 0 23 0 27.04s N/A Link

🔻 Code Coverage Decreases vs Default Branch (3)

  • message-queue - jest 67.46% (-0.8%) - Details
  • clients-middlewares - jest 75.6% (-0.1%) - Details
  • services-auth-delegation-api - jest 50.43% (-0.04%) - Details

@robertaandersen robertaandersen added this pull request to the merge queue Dec 18, 2024
Merged via the queue into feature/unicorn-app with commit 2b74fe9 Dec 18, 2024
5 checks passed
@robertaandersen robertaandersen deleted the unicorn-pipe-rel3 branch December 18, 2024 12:58
robertaandersen added a commit that referenced this pull request Dec 20, 2024
* feat: cd test app

* fix: rename app

* fix: name

* fix: added dummy queries and codegen target

* fix: eslint

* fix: style

* fix: import query

* fix: import shared type

* fix: affect shared/types

* fix: add docker-next target

* fix: nx project and infra

* chore: eslint

* chore: eslint

* chore: remove jsx-a11y

* fix: ignore css

* chore: nx format:write update dirty files

* Chore: adding unicorn to uber chart

* fix: support values file per service

* fix: cleanup

* fix: added values per service

* fix: only a single service please

* fix: set service toplevel

* fix: format

* fix: use yaml not js-yaml

* fix: remove release-tag arg

* fix: console message

* chore: remove helm values refactor

* chore: remove helm values

* chore: yarn charts

* chore: charts update dirty files

* chore: nx format:write update dirty files

* chore: charts update dirty files

* fix: make unaffected

* Unicorn pipe (#17094)

* chore: Adding pipeline for unicorns

* unicorn pipe

* unicorn pipe

* unicorn pipe

* unicorn pipe

* pipetest

* pipetest

* pipetest

* chore: nx format:write update dirty files

* Update .github/workflows/unicorns.yml

Co-authored-by: Jón Levy <levy@andes.is>

* suggestions

* chore: nx format:write update dirty files

* unicorn pipe

* suggestions

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: Jón Levy <levy@andes.is>

* chore: charts update dirty files

* chore: Adding pipeline to detect unicorns (#17165)

* chore: Adding tests if pipeline should run on unicorns

* chore: nx format:write update dirty files

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: find release branch

* chore: nx format:write update dirty files

* chore: find release branch

* chore: find release branch

* cleanup

* branch sync

* mergequeue

* chore: testing pipeline

* chore: nx format:write update dirty files

* ignore

* ignore

* ignore

* testing pipeline

* testing pipeline

* testing pipeline

---------

Co-authored-by: andes-it <builders@andes.is>

* chore: nx format:write update dirty files

* chore: testing mergequeue

* Adding mergequeue ci

* chore: testing mergequeue

* chore: testing mergequeue

* Uni pr (#17280)

* chore: testing mergequeue

* Adding mergequeue ci

* chore: testing mergequeue

* chore: testing mergequeue

* chore: testing mergequeue

* chore: testing mergequeue

* chore: nx format:write update dirty files

* chore: nx format:write update dirty files

* chore: testing mergequeue

* chore: testing mergequeue

* Uni pr (#17280)

* chore: testing mergequeue

* Adding mergequeue ci

* chore: testing mergequeue

* chore: testing mergequeue

* chore: testing mergequeue

---------

Co-authored-by: Jón Levy <levy@andes.is>
Co-authored-by: andes-it <builders@andes.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants