fix: add missing ns grant to api for bff

[brynjarorng]

Fix bff api

API needs a grant to allow bff communications for the service portal

Summary by CodeRabbit

• New Features

  • Introduced a new service: portals-my-pages.
  • Expanded the grantNamespaces for the api service to include portals-my-pages.

• Enhancements

  • Updated health check paths for the api service to /health.
  • Increased maximum replicas for the api service to improve scalability.
  • Adjusted Horizontal Pod Autoscaler settings for better resource management.

• Bug Fixes

  • Ensured consistency in health check configurations across environments.

[svanaeinars]

LGTM

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications across several configuration files related to service deployment in a Kubernetes environment. Key changes include the addition of the portals-my-pages namespace to various services, updates to health check paths, and adjustments to Horizontal Pod Autoscaler (HPA) settings. The values.dev.yaml, values.prod.yaml, and values.staging.yaml files for the API service and other services have been updated to reflect these changes, enhancing scalability and resource management.

Changes

File Path	Change Summary
apps/api/infra/api.ts	Added 'portals-my-pages' to grantNamespaces in serviceSetup function.
charts/islandis/values.dev.yaml	Added portals-my-pages service, updated api service health check paths and HPA settings.
charts/islandis/values.prod.yaml	Added portals-my-pages namespace under api, updated HPA settings, ingress configurations.
charts/islandis/values.staging.yaml	Updated api service namespace to islandis, health check paths, and added new services.
charts/services/api/values.dev.yaml	Added portals-my-pages to grantNamespaces.
charts/services/api/values.prod.yaml	Added portals-my-pages to grantNamespaces.
charts/services/api/values.staging.yaml	Added portals-my-pages to grantNamespaces, updated health check and HPA configurations.

Possibly related PRs

• fix: added missing grant to auth ids api for user notification #16680: This PR adds the portals-my-pages namespace to the grantNamespaces list in the values.dev.yaml configuration for the API service, which is directly related to the changes made in the main PR that also involves expanding the grantNamespaces for the serviceSetup function.
• revert: "fix: added missing grant to auth ids api for user notification (#16680)" #16693: This PR reverts the addition of the user-notification namespace to the grantNamespaces list in the ids-api.ts, which is relevant as it involves changes to namespace grants similar to those in the main PR.
• fix: Add namespace grants for services that need it, but don't have it #16697: This PR adds the nginx-ingress-external namespace to the grantNamespaces in the identity-server.ts, which is related to the main PR's focus on modifying namespace grants.
• fix(download-service): Grant namespace to bff admin portal #16728: This PR updates the download-service.ts to include services-bff-portals-admin in the grantNamespaces, which aligns with the main PR's changes to namespace permissions.
• chore(delegation-api): Add missing infra config. #17059: This PR adds the NATIONAL_REGISTRY_B2C_CLIENT_SECRET to the delegation-api.ts, which is relevant as it involves configuration changes that may relate to the namespace management in the main PR.

Suggested reviewers

• lodmfjord
• thordurhhh
• Toti91
• svanaeinars

Warning

Rate limit exceeded

@brynjarorng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca2d70 and 8e3deaa.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca2d70 and 8e3deaa.

📒 Files selected for processing (7)

• apps/api/infra/api.ts (1 hunks)
• charts/islandis/values.dev.yaml (1 hunks)
• charts/islandis/values.prod.yaml (1 hunks)
• charts/islandis/values.staging.yaml (1 hunks)
• charts/services/api/values.dev.yaml (1 hunks)
• charts/services/api/values.prod.yaml (1 hunks)
• charts/services/api/values.staging.yaml (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.