fix(ads-my-pages): ADS explicit and vaccine - hotfix

[thordurhhh]

Hotfixing:

#17193 - ADS
#17138 - Vaccine tweaks

Summary by CodeRabbit

• New Features

  • Introduced manual discount code creation functionality.
  • Enhanced user fund retrieval with new optional parameters.
  • Updated Vaccination API with new required parameters and improved error handling.

• Bug Fixes

  • Improved logging for user fund checks and discount code creation.

• Documentation

  • Updated API specifications for clarity and accuracy.

• Refactor

  • Replaced IntroHeader with IntroWrapper in multiple components to streamline layout.
  • Adjusted sorting behavior in the SortedVaccinationsTable component.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several enhancements across multiple services and components. The DiscountService now includes improved logging and a new method for manual discount code creation. The UserService has been updated to accommodate new parameters for fund retrieval. Changes to the Vaccination API include parameter renaming and schema updates. Additionally, UI components like SortableTable, HealthOverview, and VaccinationsWrapper have been modified to replace IntroHeader with IntroWrapper, and adjustments have been made to import statements and sorting behaviors.

Changes

File	Change Summary
apps/air-discount-scheme/backend/src/app/modules/discount/discount.service.ts	Added logger dependency, updated createExplicitDiscountCode method to include isManual parameter, introduced createManualDiscountCode method.
apps/air-discount-scheme/backend/src/app/modules/discount/test/unit/discount.service.spec.ts	Updated LOGGER_PROVIDER mock methods to use Jest functions for enhanced testing.
apps/air-discount-scheme/backend/src/app/modules/user/user.service.ts	Added DEFAULT_FUND constant, updated getFund, getUserByNationalId, and getUserInfoByNationalId methods to include isManual and isExplicit parameters for improved fund retrieval.
libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json	Renamed age parameter to agePatient, added vaccineCodes parameter, introduced hideIfNoVaccinations property in schemas, and added 404 response for specific endpoint.
libs/portals/my-pages/core/src/components/SortableTable/SortableTable.tsx	Reordered import statements and added disabled prop to the Tag component in rendering logic.
libs/portals/my-pages/health/src/screens/HealthOverview/HealthOverview.tsx	Replaced IntroHeader with IntroWrapper, adjusted import statements, and maintained existing error handling and loading logic.
libs/portals/my-pages/health/src/screens/Vaccinations/VaccinationsWrapper.tsx	Replaced IntroHeader with IntroWrapper, adjusted imports, and retained existing rendering logic.
libs/portals/my-pages/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx	Reordered imports and changed the defaultSortByKey from "vaccine" to "status" for sorting behavior.

Possibly related PRs

• fix(ads): Update code for explicit and manual use #17193: Modifications to the DiscountService class, adding a logger and updating methods related to discount code creation.
• fix(my-pages): health vaccination tags & locale #16567: Enhancements to vaccination status handling, relevant to user-related data improvements in the main PR.
• feat(native-app): add locale to vaccinations query #16813: Introduction of a locale parameter to vaccinations query, related to user data handling in the UserService.
• fix(my-pages): small tweaks for vaccinations #17138: Tweaks for vaccinations that may relate to improvements in handling user data in the DiscountService and UserService.

Suggested labels

automerge, deploy-feature

Suggested reviewers

• thorkellmani
• disaerna

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5c8c1b9 and 4aab49d.

📒 Files selected for processing (8)

• apps/air-discount-scheme/backend/src/app/modules/discount/discount.service.ts (6 hunks)
• apps/air-discount-scheme/backend/src/app/modules/discount/test/unit/discount.service.spec.ts (1 hunks)
• apps/air-discount-scheme/backend/src/app/modules/user/user.service.ts (3 hunks)
• libs/clients/health-directorate/src/lib/clients/vaccinations/clientConfig.json (8 hunks)
• libs/portals/my-pages/core/src/components/SortableTable/SortableTable.tsx (3 hunks)
• libs/portals/my-pages/health/src/screens/HealthOverview/HealthOverview.tsx (4 hunks)
• libs/portals/my-pages/health/src/screens/Vaccinations/VaccinationsWrapper.tsx (3 hunks)
• libs/portals/my-pages/health/src/screens/Vaccinations/tables/SortedVaccinationsTable.tsx (3 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.