fix(j-s): Fix empty information in merged cases fetched for defender users

[thorhildurt]

What

• Asana task
• In this PR we configure missing properties related to our limited access case endpoint for defender.
• Before these fields were added in merged cases overview for the defender users, but showed empty values since they were not configured fully.
• Added small refactoring to make naming consistent, as well as removing some unused variables

Why

• Not expected behaviour to have empty fields on the defender overview for merged cases

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Spelling Updates

  • Corrected spelling from "offence" to "offense" across multiple components and files
  • Updated terminology for consistency in spelling

• Data Retrieval Improvements

  • Enhanced merged cases data retrieval by adding court, judge, and prosecutors office information
  • Expanded GraphQL query to include additional case-related details

• Minor Code Refinements

  • Removed defendantService from a controller's constructor
  • Minor comment and variable name adjustments

[coderabbitai]

Walkthrough

This pull request encompasses multiple changes across the judicial system's backend and web applications. The modifications primarily involve updating terminology from British English ("offence") to American English ("offense") in various components and services. Additionally, the LimitedAccessCaseService has been enhanced with more comprehensive data retrieval capabilities by adding include statements for court, judge, and prosecutors office information in merged cases. The LimitedAccessCaseController has also been updated to remove the defendantService from its constructor.

Changes

File	Change Summary
apps/judicial-system/backend/src/app/modules/case/limitedAccessCase.controller.ts	Removed defendantService from constructor parameters
apps/judicial-system/backend/src/app/modules/case/limitedAccessCase.service.ts	Added include statements for Institution and User models in merged cases
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql	Added court, judge, and prosecutorsOffice fields to mergedCases query
apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx	Replaced "offence" with "offense" in variable names
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx	Replaced "offence" with "offense" in variable names
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.strings.ts	Renamed key offence to offense in strings object
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx	Updated variable names from "offences" to "offenses"
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Indictment/Indictment.tsx	Updated comment from "offence" to "offense"
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Indictment/IndictmentCount.spec.tsx	Updated test case description from "offence" to "offense"
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Indictment/IndictmentCount.tsx	Changed variable offence to offense for consistency

Possibly related PRs

• feat(j-s): Indictment overview for prison users #15357: Changes in case service interactions.
• fix(j-s): Handle no defender assigned in indictment case InfoCard #15414: Updates in the DefendantInfo component to handle cases without defenders.
• feat(j-s): Display connected indictment case files  #15526: Changes in the CaseService for querying merged cases.
• fix(j-s): Defender File Display #15821: Modifications to case data retrieval in GraphQL.
• fix(my-pages): Law and Order - error handling #16506: Changes in the Indictment component regarding comments.
• fix(j-s): Display correct verdict appeal info for defenders  #16533: Modifications in the DefendantInfo component for verdict appeal information.
• fix(j-s): Service Certificate #16566: Removal of the getServiceCertificatePdf method in the LimitedAccessFileController.
• fix(j-s): Generated PDFs #16625: Streamlining rendering of case files in the IndictmentOverview component.
• fix(j-s): Fix InfoCard #16830: Updates in the DefendantInfo component for service requirements display.
• feat(j-s): Show district court abbreviation on mobile  #17075: Addition of court abbreviation to case information.
• feat(j-s): Show indictment decision type to public prosecutor users #17079: Changes to display indictment decision types.
• fix(j-s): Render sent to prison admin files for FMST #17264: Modifications to include new case file categories in the LimitedAccessCaseService.
• fix(j-s): Add missing court case number to info card #17348: Addition of court case number to the InfoCard component.
• fix(j-s): Add case info also to reception and assignment component #17360: Enhancements to the ReceptionAndAssignment component for case information.

Suggested reviewers

• unakb

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6791ef2 and ef6f2f6.

📒 Files selected for processing (3)

• apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx (2 hunks)
• apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (2 hunks)
• apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx
• apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx
• apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (e49258c) to head (ef6f2f6).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...secutor/Indictments/Indictment/IndictmentCount.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17364      +/-   ##
==========================================
- Coverage   35.68%   35.68%   -0.01%     
==========================================
  Files        6931     6931              
  Lines      148795   148793       -2     
  Branches    42513    42512       -1     
==========================================
- Hits        53098    53096       -2     
  Misses      95697    95697              

Flag	Coverage Δ
judicial-system-backend	55.97% <ø> (-0.01%)	⬇️
judicial-system-web	27.75% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/app/modules/case/limitedAccessCase.controller.ts	97.50% <ø> (-0.05%)	⬇️
.../src/app/modules/case/limitedAccessCase.service.ts	72.56% <ø> (ø)
...c/components/InfoCard/InfoCardActiveIndictment.tsx	10.00% <ø> (ø)
...c/components/InfoCard/InfoCardClosedIndictment.tsx	6.25% <ø> (ø)
...rc/components/InfoCard/useInfoCardItems.strings.ts	100.00% <ø> (ø)
...m/web/src/components/InfoCard/useInfoCardItems.tsx	70.11% <100.00%> (ø)
...s/Prosecutor/Indictments/Indictment/Indictment.tsx	0.00% <ø> (ø)
...secutor/Indictments/Indictment/IndictmentCount.tsx	30.27% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49258c...ef6f2f6. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs d34dc0f 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
➡️ Test Sessions change in coverage: 2 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
judicial-system-backend	0	0	0	21056	0	18m 17.21s	1 no change	Link
judicial-system-web	0	0	0	344	0	55.35s	1 no change	Link