feat(j-s): show case number on infocard #17518
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. WalkthroughThe pull request introduces changes to the Judicial System web application's InfoCard component, focusing on refining the logic for displaying merge case information. Key modifications include the addition of a new function Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17518 +/- ##
==========================================
+ Coverage 35.61% 35.63% +0.02%
==========================================
Files 7017 7014 -3
Lines 150430 150265 -165
Branches 42974 42925 -49
==========================================
- Hits 53570 53544 -26
+ Misses 96860 96721 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
You also need to change |
|
I fixed the check and updated the label which was a super tiny task in this asana ticket. Screenshot: |
…s/show-merged-case-number-outside-of-system
…://github.com/island-is/island.is into j-s/show-merged-case-number-outside-of-system
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx(3 hunks)apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.strings.ts(1 hunks)apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.strings.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (4)
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (3)
4-4: LGTM!Clean import of the utility function.
44-46: LGTM!Clear and descriptive variable name with proper type inference. The condition correctly checks both the array's content and its first element.
70-70: LGTM!Clean usage of the spread operator for conditional array inclusion.
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.strings.ts (1)
75-80: LGTM!Well-structured message definition with clear ID, proper variable interpolation, and helpful description.
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.tsx
Outdated
Show resolved
Hide resolved
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx
Outdated
Show resolved
Hide resolved
thorhildurt
added
the
deprecated:automerge
gudjong
removed
the
deprecated:automerge
robertaandersen
deleted the
j-s/show-merged-case-number-outside-of-system
branch
Asana task
What
Why
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
New Features
Improvements
Localization
The changes improve the information presentation and handling of merge case details in the judicial system web application.