fix(j-s): Fine Sent to Prison Admin Tag

[gudjong]

Fine Sent to Prison Admin Tag

Viðurlagaákvörðun - sést ekki staðan Til fullnustu á málalistanum.

What

• Displays the tag "Til fullnustu" when a fine has been sent to the prison admin.

Why

• Verified bug.

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Updated verdict view tag generation logic to improve case ruling display
  • Refined conditions for rendering verdict tags, particularly for cases involving prison administration and fines

The changes modify how case verdicts are visually represented, ensuring more accurate and context-specific tag rendering for reviewed cases.

[coderabbitai]

Walkthrough

The pull request modifies the CasesReviewed.tsx file, specifically altering the getVerdictViewTag function's logic. The changes involve restructuring the conditional checks for determining the verdict view tag's display. The primary modification is in the order and conditions of checking defendant status, particularly focusing on cases involving prison administration and fine decisions. This change impacts how verdict tags are generated and displayed based on the case's specific attributes.

Changes

File	Change Summary
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx	Restructured getVerdictViewTag function logic, modifying conditions for generating verdict view tags

Suggested labels

automerge, high priority

Suggested reviewers

• oddsson

Possibly related PRs

• feat(j-s): Table for reviewed cases #14778: Modifications to CasesReviewed.tsx file for reviewed cases display
• feat(j-s): Display defendant appealed verdict tag for public prosecutor #17303: Added functionality for displaying defendant verdict appeal tags
• fix(j-s): Show sentToPrisonAdmin in FINE cases #17534: Enhanced display logic for FINE cases in related components

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a548dd and 66582db.

📒 Files selected for processing (1)

• apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

📓 Learnings (1)

apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (3)

Learnt from: oddsson
PR: island-is/island.is#14673
File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79
Timestamp: 2024-11-12T15:15:11.835Z
Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.

Learnt from: unakb
PR: island-is/island.is#15378
File: apps/judicial-system/web/src/routes/Court/Indictments/Summary/Summary.tsx:86-100
Timestamp: 2024-11-12T15:15:11.835Z
Learning: User unakb prefers explicit case handling in switch statements for key functionalities like `getRulingDecisionTagColor` to ensure clarity and avoid assumptions that a case was overlooked.

Learnt from: thorhildurt
PR: island-is/island.is#17285
File: apps/judicial-system/web/src/routes/Shared/Cases/PrisonCases.tsx:223-225
Timestamp: 2024-12-18T17:15:59.181Z
Learning: The system currently only allows adding one defendant, so the punishment type logic in the table can default to the first defendant, with a plan to support multiple defendants in the future.

🔇 Additional comments (2)

apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (2)

66-69: LGTM! The prison admin check is well-implemented.

The new condition correctly checks if any defendant is sent to prison administration and sets appropriate tag properties. The implementation aligns with the PR objective to display the "Til fullnustu" tag.

---

69-72: Verify the order of conditions.

The reordering of conditions ensures that the prison admin tag takes precedence over the fine check. This is important as it determines which tag is displayed when multiple conditions are true.

Let's verify that this is the intended behavior:

✅ Verification successful

The condition order is correctly implemented

The current order ensures that:

1. Prison admin status takes precedence as it represents a critical state
2. Fine cases show no tag (return null)
3. Other verdict view states are only checked for non-fine cases

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if there are any other components that implement similar tag priority logic
# This helps ensure consistency across the application

ast-grep --pattern 'if ($someDefendantIsSentToPrisonAdmin) {
  $$$
} else if ($indictmentRulingDecision === CaseIndictmentRulingDecision.FINE) {
  $$$
}'

Length of output: 155

---

Script:

#!/bin/bash
# Get the full component implementation
cat "apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx"

# Search for similar conditional patterns
rg "CaseIndictmentRulingDecision" -A 5 -B 5

Length of output: 66031

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.58%. Comparing base (c75825f) to head (66582db).
Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/routes/PublicProsecutor/Tables/CasesReviewed.tsx	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17557   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files        7027     7027           
  Lines      150397   150397           
  Branches    42924    42924           
=======================================
  Hits        53517    53517           
  Misses      96880    96880           

Flag	Coverage Δ
judicial-system-web	27.97% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/routes/PublicProsecutor/Tables/CasesReviewed.tsx	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a548dd...66582db. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/indictment-fine-sent-to-prison-admin
Commit report: c083490
Test service: judicial-system-web

✅ 0 Failed, 333 Passed, 0 Skipped, 58.01s Total Time
➡️ Test Sessions change in coverage: 1 no change