fix(j-s): Info in alert message for connected cases

[unakb]

Laga texta í gula boxi - sameinað mál

What

Fix text in alert message for connected cases

Why

Cleaner UI

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Style

  • Updated text message for cases when no open cases are found
  • Removed title from alert message when no connected cases are available

• Documentation

  • Refined messaging for case selection interface

[coderabbitai]

Walkthrough

This pull request modifies the localization strings and component rendering for the SelectConnectedCase feature in the judicial system web application. The changes involve removing the title from an alert message when no connected cases are found and updating the message text. The modification is specific to the case selection interface, focusing on how no-case scenarios are presented to users.

Changes

File	Change Summary
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.strings.ts	- Removed noConnectedCasesTitle message - Updated noConnectedCasesMessage ID and default message text
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx	- Removed title property from AlertMessage when no connected cases are found

Possibly related PRs

• fix(j-s): Show indictment info always #17549: Ensures indictment information visibility, addressing regression issues
• fix(j-s): Show sentToPrisonAdmin in FINE cases #17534: Enhances display of FINE case information sent to prison administration
• fix(j-s): Fine Sent to Prison Admin Tag #17557: Adds "Til fullnustu" tag for fines sent to prison administration

Suggested labels

automerge

Suggested reviewers

• oddsson

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27f0c9a and 858bb5e.

📒 Files selected for processing (2)

• apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.strings.ts (1 hunks)
• apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.strings.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (1)

apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.strings.ts (1)

17-18: LGTM! Verify message ID references.

The message changes improve clarity in Icelandic. However, since the message ID has changed, we should verify that all references are updated.

Let's verify that the message ID is updated everywhere it's used:

✅ Verification successful

Message ID change is properly implemented ✅

The new message ID is correctly referenced in the component, and no stale references to the old ID were found in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old message ID
rg "judicial.system.core:court.indictments.conclusion.select_connected_case.no_connected_cases_text"

# Search for references to the new message ID to confirm proper usage
rg "judicial.system.core:court.indictments.conclusion.select_connected_case.no_connected_cases_message"

Length of output: 410

---

Script:

#!/bin/bash
# Find files importing SelectConnectedCase.strings
rg -l "SelectConnectedCase\.strings"

# Check the content of files that might use these strings
rg -l "SelectConnectedCase" apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/

Length of output: 390

---

Script:

#!/bin/bash
# Check the content of the component file
echo "=== SelectConnectedCase.tsx ==="
rg -A 5 -B 5 "noConnectedCases" apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx

# Check the content of the parent component
echo "=== Conclusion.tsx ==="
rg -A 5 -B 5 "noConnectedCases" apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx

Length of output: 648

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[thorhildurt]

👌