Fix issue #27 on override thread discovery with custom data-attributes #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Cool, thanks! Manually adding the title is really something that has been missing. I'll test the custom thread id later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a fix for the use of data-isso-id.
The problem was that thread ids needs to be URL because of an http curl used to check title of the page.
I changed this behaviour a little by saying that if you provide a title (using the data-title documented in the client configuration), we don't need to send a curl request to get the title and just grab it. Incidently it makes custom thread id work since the curl to get the title is the only reason thread id is an URL (at least I didn't was any other need for this constraint).
Tell me if any changes needs to be made to the PR.