Add Disqus or Isso comments box on a permalink page #181

NerosTie · 2015-03-30T15:08:26Z

It could be very great to have a comments box on permalink pages.
Major improvment: you can chat! Instead of chatting via multiple "shaarli river" instances.

I'm trying to add this in shaarli for isso:

<script data-isso="//sub.mydomain.tld/"
    src="//sub.mydomain.tld/js/embed.min.js"></script>
<div><section id="isso-thread"></section></div>

But I have no idea how "pages" work in shaarli.
Can you help me please?

http://posativ.org/isso/

(I think issue #175 must be fixed to work well, because Isso needs the title)

The text was updated successfully, but these errors were encountered:

nodiscc · 2015-03-30T15:34:03Z

Hi, this is similar to previously requested "comment systems". It was decided that Shaarli could include external comments systems through plugins: have a look at the pull request #164. It's not merged yet, but it provides a way to add custom elements to Shaarli's template.

Basically, using this branch, you can:

add <script data-isso="//sub.mydomain.tld/" src="//sub.mydomain.tld/js/embed.min.js"></script> to tpl/plugins/isso/isso.includes.html and it will be included in the page <head>
add <div><section id="isso-thread"></section></div> to tpl/plugins/isso/isso.linklist.html and it will be included for each link, in the link info bar.

I guess you need to specify different ids, else your isso comments thread will be the same for all displayed links. For example you could use somtehing like id="isso-thread-$permalink" and have each div render a different comments thread, I don't how isso handles that.

Anyway this is a very good use case for the planned plugin system, I can make changes to the pull request if you need more features/want to do things differently. Your ideas are welcome.

NerosTie · 2015-03-30T16:23:21Z

Thanks! I will wait the merge of #164 and I will try again.

nodiscc · 2015-04-02T19:00:30Z

@NerosTie I've read the isso doc and this should be doable, check https://github.com/nodiscc/Shaarli/blob/new-plugin-system/tpl/plugins/TODO.md. You would have to first click a permalink to see comments on this article. The linklist would only show a 0 comments, 15 comments ... counter for each shaarlink (no full comments threads in the linklist, only in permalink view)

Isso comments

NerosTie · 2016-06-02T20:02:04Z

I'm writing a plugin with Isso but I don't find how to activate it only on a permalink page.

I have this line: if($data['_PAGE_'] == Router::$PAGE_LINKLIST){

But it will activate the plugin on the homepage and this is not the expected behavior.

Thanks!

ArthurHoaro · 2016-06-02T20:17:43Z

We tried, but couldn't make it work because we weren't able to have a separate thread for different shaare. It looked like we could only have a thread based on the URL index.php/?.

ArthurHoaro@5670545
(it's probably outdated because of search refactoring, but you want to enable it if you have 1 link in $data)

NerosTie · 2016-06-02T20:39:25Z

It seems to be more complicated than expected... (it was not that hard for Ghost).

Also, there is Hashover: https://github.com/jacobwb/hashover
In action: https://hal-9000.fr/?exgXpg

It could be an alternative.

virtualtam · 2016-06-02T22:27:58Z

Thanks @NerosTie for sharing :)

@ArthurHoaro looks like we're good to add a Hashover plugin ^^

ArthurHoaro · 2016-06-03T07:23:02Z

Yup, this looks good enough. @NerosTie, do you want to work on it?

NerosTie · 2016-06-05T14:13:19Z

@ArthurHoaro I can try, but I think I will have the same issue with the homepage.

ArthurHoaro · 2016-06-06T15:10:00Z

Ok, I'll look into it.

ArthurHoaro · 2016-06-06T16:59:12Z

Actually, I don't think we should make a Hashover plugin. Its code is rather low quality, and its configuration can't be externalized easily. But most importantly, home made encryption functions and storing clear passwords in the configuration file and cookies (!) make me worried about security.

kalvn · 2016-06-06T17:36:01Z

I made a quick Disqus plugin: https://github.com/kalvn/shaarli-plugin-disqus
Don't forget to set your Disqus shortname in the plugin administration page.

The tricky part was to ensure we are on the permalink page but it should work properly.
Let me know if you think it might be useful to add it as a default plugin and want to move it to the Shaarli repo.

ArthurHoaro · 2016-06-06T18:04:30Z

Other opinions are welcome, but I'd rather have a solution which doesn't rely on a commercial 3rd party in the main repo. Add it to the wiki though.

kalvn · 2016-06-06T18:06:05Z

I fully agree. I'll see what is doable with Isso.

mro · 2016-06-06T19:18:26Z

Maybe https://github.com/jacobwb/hashover-next is worth a look.

NerosTie · 2016-06-10T13:52:15Z

I have something for Isso but I need help:

https://github.com/NerosTie/isso/

It works, you can comment, but Isso can't find the title and the link is the same everywhere because permalinks begin with ?

ArthurHoaro · 2016-06-10T15:34:57Z

That's what I said #181 (comment)

NerosTie · 2016-06-10T15:39:34Z

Exact, I forgot about this....

So, there is no possible solution?

ArthurHoaro · 2016-06-10T15:43:02Z

Except if we missed something, I'm afraid it can't work until they fix their data-isso-id tag, or add any way to specify the thread we're in.

NerosTie · 2016-06-10T18:15:30Z

There is a PR here: blatinier/isso@f1325cc

Maybe it helps

EDIT: nope.

ArthurHoaro · 2016-06-13T07:23:52Z

Maybe https://github.com/jacobwb/hashover-next is worth a look.

It looks way better! I'll try to end up with something.
Although, it's a lot of LOC, I think we should have a separate repo for this.

EDIT: or maybe Shaarli can act as a client... I'll see.

kalvn · 2016-06-13T16:45:30Z

Yes I think it would be better to keep things separated and only add this as a plugin for the client part.

NerosTie · 2016-09-21T13:15:13Z

Isso 0.10.5 has been released and there is this:

clients can now use data-title to get the HTML title for a new page

isso-comments/isso#252
https://github.com/posativ/isso/releases/tag/0.10.5

Maybe it would help for the plugin in Shaarli?

ArthurHoaro · 2016-10-03T07:40:37Z

It's working! o/

NerosTie · 2016-10-03T22:45:51Z

Yeah! It's a good news! 🎉

NerosTie · 2016-11-21T18:55:50Z

So, it works? Can I close this issue? (I can't test it right now, unfortunately)

ArthurHoaro · 2016-11-21T19:24:21Z

Yup. I don't use it, but give us your feedback if you have the time to test it.

poVoq · 2018-01-30T17:30:46Z

Has there ever been any additional work on integrating Hashover-next or a similar php based comment application? Isso is cool, but needs Python which isn't available on many shared-hosts that Shaarli runs on.

ArthurHoaro · 2018-01-30T18:28:47Z

Not that I'm aware of. Feel free to provide PR or open another issue regarding a Hashover-next plugin though.

poVoq · 2018-02-01T19:38:11Z

Made a alpha version of a plugin that integrates Hashover-Next:
https://github.com/poVoq/shaarli-plugin-hashover-comments

nodiscc added plugin bells and whistles feature labels Mar 30, 2015

nodiscc mentioned this issue Mar 31, 2015

Ajout d'un système de commentaires et d'une fonction ping sebsauvage/Shaarli#170

Open

nodiscc self-assigned this Apr 2, 2015

nodiscc added this to the 1.0 milestone Apr 14, 2015

nodiscc modified the milestones: future, 1.0 May 11, 2015

nodiscc mentioned this issue May 11, 2015

Plugin system #14

Closed

nodiscc mentioned this issue Jun 14, 2015

External pingback server integration #225

Closed

ArthurHoaro pushed a commit to ArthurHoaro/Shaarli that referenced this issue Jul 12, 2015

Add plugin todo about shaarli#181

724d171

Isso comments

nodiscc added a commit that referenced this issue Jul 12, 2015

Add plugin todo about #181

dc44ed6

Isso comments

nodiscc removed their assignment Jul 26, 2015

ArthurHoaro mentioned this issue Oct 3, 2016

Isso comments plugin #651

Merged

ArthurHoaro closed this as completed Nov 21, 2016

ArthurHoaro modified the milestones: 0.8.1, backlog to the future Nov 21, 2016

poVoq mentioned this issue Jan 30, 2018

Add a self-hosted php based commenting system? #1066

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Disqus or Isso comments box on a permalink page #181

Add Disqus or Isso comments box on a permalink page #181

NerosTie commented Mar 30, 2015

nodiscc commented Mar 30, 2015

NerosTie commented Mar 30, 2015

nodiscc commented Apr 2, 2015

NerosTie commented Jun 2, 2016

ArthurHoaro commented Jun 2, 2016

NerosTie commented Jun 2, 2016

virtualtam commented Jun 2, 2016

ArthurHoaro commented Jun 3, 2016

NerosTie commented Jun 5, 2016

ArthurHoaro commented Jun 6, 2016

ArthurHoaro commented Jun 6, 2016

kalvn commented Jun 6, 2016

ArthurHoaro commented Jun 6, 2016

kalvn commented Jun 6, 2016

mro commented Jun 6, 2016

NerosTie commented Jun 10, 2016

ArthurHoaro commented Jun 10, 2016

NerosTie commented Jun 10, 2016

ArthurHoaro commented Jun 10, 2016

NerosTie commented Jun 10, 2016 •

edited

Loading

ArthurHoaro commented Jun 13, 2016 •

edited

Loading

kalvn commented Jun 13, 2016

NerosTie commented Sep 21, 2016

ArthurHoaro commented Oct 3, 2016

NerosTie commented Oct 3, 2016

NerosTie commented Nov 21, 2016

ArthurHoaro commented Nov 21, 2016

poVoq commented Jan 30, 2018

ArthurHoaro commented Jan 30, 2018

poVoq commented Feb 1, 2018

Add Disqus or Isso comments box on a permalink page #181

Add Disqus or Isso comments box on a permalink page #181

Comments

NerosTie commented Mar 30, 2015

nodiscc commented Mar 30, 2015

NerosTie commented Mar 30, 2015

nodiscc commented Apr 2, 2015

NerosTie commented Jun 2, 2016

ArthurHoaro commented Jun 2, 2016

NerosTie commented Jun 2, 2016

virtualtam commented Jun 2, 2016

ArthurHoaro commented Jun 3, 2016

NerosTie commented Jun 5, 2016

ArthurHoaro commented Jun 6, 2016

ArthurHoaro commented Jun 6, 2016

kalvn commented Jun 6, 2016

ArthurHoaro commented Jun 6, 2016

kalvn commented Jun 6, 2016

mro commented Jun 6, 2016

NerosTie commented Jun 10, 2016

ArthurHoaro commented Jun 10, 2016

NerosTie commented Jun 10, 2016

ArthurHoaro commented Jun 10, 2016

NerosTie commented Jun 10, 2016 • edited Loading

ArthurHoaro commented Jun 13, 2016 • edited Loading

kalvn commented Jun 13, 2016

NerosTie commented Sep 21, 2016

ArthurHoaro commented Oct 3, 2016

NerosTie commented Oct 3, 2016

NerosTie commented Nov 21, 2016

ArthurHoaro commented Nov 21, 2016

poVoq commented Jan 30, 2018

ArthurHoaro commented Jan 30, 2018

poVoq commented Feb 1, 2018

NerosTie commented Jun 10, 2016 •

edited

Loading

ArthurHoaro commented Jun 13, 2016 •

edited

Loading