feat: add delete option to instrument command
#1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync repo
Bring fork up to date
test: stop using LAZY_LOAD_COUNT (istanbuljs#960)
Get latest
Get latest
Get Latest
feat: add support to exclude files on coverage report generation (istanbuljs#982)
Get latest
With this change you can now tell nyc to clean the output directory when instrumenting, to do this an output directory must be specified. I've currently set the default value for this to false so it can be a non-breaking change, although the default behaviour should be changed to true in the next major release. I've included tests for this behaviour, and introduced lint support for `afterEach` and required the `makeDir` module
… deleting cwd The protection against deleting cwd is a little heavy handed, but I figure if you don't want to delete your cwd and probably don't want your output files going there either. Added test support for these changes.
AndrewFinlay
changed the title
clean option to instrument commanddelete option to instrument command
|
After a chat with @coreyfarrell I've changed the name and added some level of defence against |
bcoe
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
thanks for this; I really like @coreyfarrell thinking that we should have checks and balances in place to protect us from overly eager rimrafs 😆
coreyfarrell
approved these changes
Mar 7, 2019
Never edited a file through Github's web interface before
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
--cleanswitch to the nyc instrument command, it must be set true and an output directory must be specified.I've set the default value for this to false so it can be a non-breaking change, but this should change in the next major release. I've included tests for this function, introduced lint support for
afterEachin the tests, and required themakeDirmodule.