Fix error handling in deployBookinfo #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
luksa
approved these changes
Oct 7, 2024
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 7, 2024
* upstream/main: (26 commits) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) Show name of active revision in Istio/RemoteIstio status (istio-ecosystem#350) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 7, 2024
* upstream/main: (26 commits) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) Show name of active revision in Istio/RemoteIstio status (istio-ecosystem#350) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 7, 2024
* upstream/main: (26 commits) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) Show name of active revision in Istio/RemoteIstio status (istio-ecosystem#350) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 7, 2024
* upstream/main: (27 commits) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 7, 2024
* upstream/main: (27 commits) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (27 commits) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (27 commits) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) Add External Controlplane to user docs (istio-ecosystem#335) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (28 commits) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) Adding E2e multicluster test (istio-ecosystem#342) Use Kubernetes defaults for imagePullPolicy (istio-ecosystem#352) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (30 commits) Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) Add ability to specify resources in helm chart (istio-ecosystem#375) Update dependencies and fix transform (istio-ecosystem#374) E2E kubectl util refactor (istio-ecosystem#368) Update helm chart README (istio-ecosystem#370) Add pull request template (istio-ecosystem#366) Fix formatting in the charts readme page (istio-ecosystem#364) Add CODE-OF-CONDUCT to the project (istio-ecosystem#362) Update test labels in the wayofwork documentation (istio-ecosystem#359) Automatically adjust default release channel (istio-ecosystem#353) Adding wait after olm install in olm test setup (istio-ecosystem#357) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (40 commits) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) Implement e2e dualStack control plane tests (istio-ecosystem#373) Improve pull request template (istio-ecosystem#376) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (42 commits) Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) Adding default value for IP_FAMILY (istio-ecosystem#378) Update/Fix Istioctl links and docs (istio-ecosystem#349) Fix broken url for sample gateway (istio-ecosystem#377) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 8, 2024
* upstream/main: (45 commits) Replace `manager` with `sail-operator` for the binary name Fix the update location for the rbac proxy Add the make clean target Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 9, 2024
* upstream/main: (45 commits) Replace `manager` with `sail-operator` for the binary name Fix the update location for the rbac proxy Add the make clean target Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 9, 2024
* upstream/main: (45 commits) Replace `manager` with `sail-operator` for the binary name Fix the update location for the rbac proxy Add the make clean target Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 9, 2024
* upstream/main: (45 commits) Replace `manager` with `sail-operator` for the binary name Fix the update location for the rbac proxy Add the make clean target Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 9, 2024
* upstream/main: (45 commits) Replace `manager` with `sail-operator` for the binary name Fix the update location for the rbac proxy Add the make clean target Improve kubectl utility in e2e tests (istio-ecosystem#394) Don't add istiod-remote chart when updating latest version (istio-ecosystem#396) Make patch-csv.sh more readable Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions Print Istio CNI logs when test fails Temporarily disable RemoteIstio tests for 1.24+ Make gen Add generics to EnqueueEventLogger and AdditionNotifierQueue Update Istio versions Remove reference to istiod-remote chart Ensure crd-all.gen.yaml file is found in newer and older Istio versions Add Helm artifacts publish automation (istio-ecosystem#385) Simplify supportedversion.go and add unit tests (istio-ecosystem#391) Clean up code (istio-ecosystem#392) Implement e2e dualStack data plane tests (istio-ecosystem#383) Fix error handling in deployBookinfo (istio-ecosystem#384) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.