Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify supportedversion.go and add unit tests #391

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Simplify supportedversion.go and add unit tests #391

merged 4 commits into from
Oct 8, 2024

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Oct 8, 2024

These tests will not just ensure that the functions in supportedversion.go are okay, but also that the versions.yaml file is valid and is parsed successfully.

@luksa luksa requested a review from a team as a code owner October 8, 2024 07:14
@luksa luksa force-pushed the versions branch 2 times, most recently from e64afff to 90910aa Compare October 8, 2024 07:26
@luksa
Simplify supportedversion.go and add unit tests
028ae42 
These tests will not just ensure that the functions in supportedversion.go are okay, but also that the versions.yaml file is valid and is parsed successfully.

Signed-off-by: Marko Lukša <mluksa@redhat.com>
@luksa luksa force-pushed the versions branch 2 times, most recently from d106e1f to 32bfbff Compare October 8, 2024 07:57
@luksa
Make GetVersionFromIstiod return a semver.Version
84d17e3 
Signed-off-by: Marko Lukša <mluksa@redhat.com>
@luksa
Make getProxyVersion() return semver.Version
e83cd00 
Signed-off-by: Marko Lukša <mluksa@redhat.com>
@luksa luksa mentioned this pull request Oct 8, 2024
Merged
@dgn
Copy link
Collaborator

dgn commented Oct 8, 2024 •
edited
Loading

Maybe we'll need to update the update version script as well to include the full version (including .commit_hash suffix)? It would be a bit annoying having to specify it though... Maybe we'll need some sort of version alias functionality

@luksa
Include commit hash in latest version in versions.yaml
51a0853 
Without the commit hash, the version number doesn't specify a single version, but a set of versions. For example, "1.24-alpha" is not just one single version, whereas "1.24-alpha.<hash>" is.

Signed-off-by: Marko Lukša <mluksa@redhat.com>
@istio-testing istio-testing merged commit a7f0980 into istio-ecosystem:main Oct 8, 2024
13 checks passed
@luksa luksa deleted the versions branch October 8, 2024 10:16
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 8, 2024
Automated merge
323d6fd 
* upstream/main: (30 commits)
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  Adding default value for IP_FAMILY (istio-ecosystem#378)
  Update/Fix Istioctl links and docs (istio-ecosystem#349)
  Fix broken url for sample gateway (istio-ecosystem#377)
  Implement e2e dualStack control plane tests (istio-ecosystem#373)
  Improve pull request template (istio-ecosystem#376)
  Add ability to specify resources in helm chart (istio-ecosystem#375)
  Update dependencies and fix transform (istio-ecosystem#374)
  E2E kubectl util refactor (istio-ecosystem#368)
  Update helm chart README (istio-ecosystem#370)
  Add pull request template (istio-ecosystem#366)
  Fix formatting in the charts readme page (istio-ecosystem#364)
  Add CODE-OF-CONDUCT to the project (istio-ecosystem#362)
  Update test labels in the wayofwork documentation (istio-ecosystem#359)
  Automatically adjust default release channel (istio-ecosystem#353)
  Adding wait after olm install in olm test setup (istio-ecosystem#357)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 8, 2024
Automated merge
049c991 
* upstream/main: (40 commits)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  Adding default value for IP_FAMILY (istio-ecosystem#378)
  Update/Fix Istioctl links and docs (istio-ecosystem#349)
  Fix broken url for sample gateway (istio-ecosystem#377)
  Implement e2e dualStack control plane tests (istio-ecosystem#373)
  Improve pull request template (istio-ecosystem#376)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 8, 2024
Automated merge
892db43 
* upstream/main: (42 commits)
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  Adding default value for IP_FAMILY (istio-ecosystem#378)
  Update/Fix Istioctl links and docs (istio-ecosystem#349)
  Fix broken url for sample gateway (istio-ecosystem#377)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 8, 2024
Automated merge
19673b5 
* upstream/main: (45 commits)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 9, 2024
Automated merge
85f0ffd 
* upstream/main: (45 commits)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 9, 2024
Automated merge
9bd840a 
* upstream/main: (45 commits)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 9, 2024
Automated merge
118cd12 
* upstream/main: (45 commits)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 9, 2024
Automated merge
2fe0735 
* upstream/main: (45 commits)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  Fix error handling in deployBookinfo (istio-ecosystem#384)
  ...
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Oct 9, 2024
Automated merge
07f7156 
* upstream/main: (46 commits)
  Create GH Action for update-deps (istio-ecosystem#393)
  Replace `manager` with `sail-operator` for the binary name
  Fix the update location for the rbac proxy
  Add the make clean target
  Improve kubectl utility in e2e tests (istio-ecosystem#394)
  Don't add istiod-remote chart when updating latest version (istio-ecosystem#396)
  Make patch-csv.sh more readable
  Fix patch-csv.sh so that it finds hub, image, and tag in newer Istio versions
  Ensure Primary-Remote e2e test is also skipped for 1.24 pre-release versions
  Print Istio CNI logs when test fails
  Temporarily disable RemoteIstio tests for 1.24+
  Make gen
  Add generics to EnqueueEventLogger and AdditionNotifierQueue
  Update Istio versions
  Remove reference to istiod-remote chart
  Ensure crd-all.gen.yaml file is found in newer and older Istio versions
  Add Helm artifacts publish automation (istio-ecosystem#385)
  Simplify supportedversion.go and add unit tests (istio-ecosystem#391)
  Clean up code (istio-ecosystem#392)
  Implement e2e dualStack data plane tests (istio-ecosystem#383)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgn dgn dgn approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luksa @dgn @istio-testing