Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test to Gateway Setup #11268

Closed
wants to merge 21 commits into from
Closed

Add Test to Gateway Setup #11268

wants to merge 21 commits into from

Conversation

dhawton
Copy link
Member

@dhawton dhawton commented May 4, 2022

Please provide a description for what this PR is for.

This adds tests to the Gateway Setup documentation

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@dhawton dhawton requested a review from a team as a code owner May 4, 2022 15:37
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines,
    and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be
    built as a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the Status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
    to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    status section of the page. Click on the Details link to get a list of the problems with your PR.
    Fix those problems and push an update to your PR. This will automatically rerun the tests and
    hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2022
@dhawton dhawton force-pushed the add-tests-to-setup-gateway branch from 9420e23 to dc95da6 Compare May 5, 2022 18:31
istio-testing and others added 18 commits May 6, 2022 11:53
@istio-testing @dhawton
Automator: update istio.io@ reference docs (istio#11237)
65a1296
@my-git9 @dhawton
zh-translation: traffic-management/index.md (istio#11217)
5f88ecb
@howardjohn @dhawton
security-vulnerabilities: add more info about base images (istio#11236)
7f2c293
@Arhell @dhawton
rollback of unnecessary changes (istio#11246)
c0d9d9f
@istio-testing @dhawton
Automator: update istio@ test reference (istio#11249)
e546cf9
@my-git9 @dhawton
[zh] Sync en docs in docs/concepts/_index.md (istio#11245)
63cd3d6 
[zh] Sync en docs in docs/concepts/_index.md
@kinzhi @dhawton
zh-translation:Update content/en/about/faq/security/verify-mtls-encry…
56f1437 
…ption.md (istio#11248)
@jasonwzm @dhawton
Add Statsig as a user (istio#11238)
aa7c3f7
@lei-tang @dhawton
User guide for Istio TLS configuration (istio#11166)
1a1837f 
* User guide for Istio TLS configuration

* Address review comments

* Fix indention

* Fix lint

* Address reviewer comments

* Address review comment
@yanrongshi @dhawton
Create istio-has-applied-to-join-the-cncf.md (istio#11260)
1a46e5e 
Co-authored-by: yanrong.shi <yanrongshi>
@yanrongshi @dhawton
zh:/news/releases/1.12.x/announcing-1.12/_index.md (istio#10730)
54306b7 
* Create _index.md

* Update _index.md
@yanrongshi @dhawton
zh:/blog/2021/direct-upgrade/index.md (istio#10741)
fe958e7 
* Create index.md

* Update index.md

* Update index.md
@yanrongshi @dhawton
Update:zh-update-/releases/security-vulnerabilities/index.md (istio#1…
cbb0463 
…1258)

* Update index.md

* Update index.md

Co-authored-by: yanrong.shi <yanrongshi>
@istio-testing @dhawton
Automator: update common-files@master in istio/istio.io@master (istio…
a1b2510 
…#11263)
@zirain @dhawton
fix multicluster prometheus (istio#11221)
915c6ef
@yanrongshi @dhawton
Update index.md (istio#11265)
f4953a4 
Co-authored-by: yanrong.shi <yanrongshi>
@dhawton
refactor rewrite-helm command into helpers util
b15b8af
@dhawton
change gateway setup to new helm rewrite helper
412f524
@dhawton dhawton requested review from a team as code owners May 6, 2022 17:56
@dhawton dhawton requested a review from a team as a code owner May 6, 2022 17:56
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 6, 2022
@istio-testing
Copy link
Contributor

@dhawton: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2022
@istio-testing
Copy link
Contributor

@dhawton: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
update-ref-docs-dry-run_istio.io 412f524 link false /test update-ref-docs-dry-run_istio.io
gencheck_istio.io 412f524 link true /test gencheck_istio.io
lint_istio.io 412f524 link true /test lint_istio.io
doc.test.profile_default_istio.io 412f524 link true /test doc.test.profile_default_istio.io
doc.test.profile_demo_istio.io 412f524 link true /test doc.test.profile_demo_istio.io
doc.test.profile_none_istio.io 412f524 link true /test doc.test.profile_none_istio.io
doc.test.multicluster_istio.io 412f524 link true /test doc.test.multicluster_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhawton dhawton closed this May 6, 2022
@dhawton dhawton mentioned this pull request May 7, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn left review comments

@frankbu frankbu frankbu left review comments

Assignees
No one assigned
Labels
kind/docs needs-rebase Indicates a PR needs to be rebased before being merged size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.