[release-1.24] Add metadata fallback for client sidecar reporters (#6028) #6075
+163
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add metadata fallback for client sidecar reporters Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Move logic Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Add test Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix compiler error Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fixup Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix ownership bug Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Don't use string_view because of scope Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
keithmattix
changed the title
istio-testing
added
the
size/L
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6028