Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: add "autopath" mode #1074

Closed
howardjohn opened this issue May 17, 2024 · 0 comments · Fixed by #1099
Closed

dns: add "autopath" mode #1074

howardjohn opened this issue May 17, 2024 · 0 comments · Fixed by #1099
Assignees

Comments

@howardjohn
Copy link
Member

Like https://coredns.io/plugins/autopath/ or the same code we have in istio-agent

This is actually a correctness issue not just performance IMO

@howardjohn howardjohn self-assigned this May 17, 2024
howardjohn added a commit to howardjohn/ztunnel that referenced this issue May 29, 2024
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
howardjohn added a commit to howardjohn/ztunnel that referenced this issue May 29, 2024
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Jun 3, 2024
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
istio-testing pushed a commit that referenced this issue Jun 4, 2024
* dns: fix search lookup

Fixes #1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(#555), but we can use the
correct defaults.

* Fix unwrap
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Jun 6, 2024
* dns: fix search lookup

Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.

* Fix unwrap

(cherry picked from commit 2e41538)
istio-testing pushed a commit that referenced this issue Jun 6, 2024
* dns: fix search lookup

Fixes #1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(#555), but we can use the
correct defaults.

* Fix unwrap

(cherry picked from commit 2e41538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant