Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per-pod DNS settings #555

Open
nmittler opened this issue Jun 19, 2023 · 5 comments
Open

Support per-pod DNS settings #555

nmittler opened this issue Jun 19, 2023 · 5 comments
Assignees
@MorrisLaw
Labels
area/configurability Area: Configurability size/TBD

Comments

@nmittler
Copy link
Contributor

nmittler commented Jun 19, 2023 •
edited by keithmattix
Loading

The DNS proxy needs a way to identify per-pod DNS settings when running as a shared (multi-tenant) proxy. The initial implementation will use the settings defined the ztunnel DaemonSet's /etc/resolv.cof for all clients running on the node. While this will likely work for most use cases, we also need to respect per-pod settings.
@bleggett bleggett added area/configurability Area: Configurability size/TBD labels Jun 21, 2023
@MorrisLaw
Copy link
Contributor

This seems like a good issue for me to get deeper on Ztunnel to help further my understanding. Can I assign this to myself @nmittler @bleggett ?

@MorrisLaw
Copy link
Contributor

Also, I think initial implementation in the description should link to this: #536

@nmittler
Copy link
Contributor Author

@MorrisLaw sure, go for it!

@MorrisLaw MorrisLaw self-assigned this Jun 26, 2023
@MorrisLaw
Copy link
Contributor

RFC link: https://docs.google.com/document/d/1P2q7VnqFDZF4Ght913wtvVRuXHF3keJItbd8UENsvu4

@MorrisLaw
Copy link
Contributor

As per the discussion in today's Ambient meeting. We'll be pausing work on this for now.

howardjohn added a commit to howardjohn/ztunnel that referenced this issue May 29, 2024
@howardjohn
dns: fix search lookup
d5a0b5b 
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
@howardjohn howardjohn mentioned this issue May 29, 2024
Merged
howardjohn added a commit to howardjohn/ztunnel that referenced this issue May 29, 2024
@howardjohn
dns: fix search lookup
5cef952 
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Jun 3, 2024
@howardjohn
dns: fix search lookup
7435f01 
Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.
istio-testing pushed a commit that referenced this issue Jun 4, 2024
@howardjohn
dns: fix search lookup (#1099)
2e41538 
* dns: fix search lookup

Fixes #1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(#555), but we can use the
correct defaults.

* Fix unwrap
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Jun 6, 2024
@howardjohn
dns: fix search lookup (istio#1099)
a67f29d 
* dns: fix search lookup

Fixes istio#1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(istio#555), but we can use the
correct defaults.

* Fix unwrap

(cherry picked from commit 2e41538)
@howardjohn howardjohn mentioned this issue Jun 6, 2024
Merged
istio-testing pushed a commit that referenced this issue Jun 6, 2024
@howardjohn
dns: fix search lookup (#1099) (#1118)
c932f45 
* dns: fix search lookup

Fixes #1074 (issue was incorrect
basically).

Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.

We don't know the per-pod custom settings
(#555), but we can use the
correct defaults.

* Fix unwrap

(cherry picked from commit 2e41538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MorrisLaw MorrisLaw

Labels
area/configurability Area: Configurability size/TBD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bleggett @nmittler @MorrisLaw