Ensure some spawns have deadlines #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
bleggett
force-pushed
the
bleggett/minor-fixes
branch
from
424ef01 to
e2187bb
Compare
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/minor-fixes
branch
from
e2187bb to
e7a03e3
Compare
howardjohn
reviewed
Apr 5, 2024
| let drain = std::pin::Pin::new(&mut server); | ||
| drain.graceful_shutdown(); | ||
| server.await | ||
| // There are scenarios where the http2 server never resolves after | ||
| // `graceful_shutdown`, which will hang the whole task. |
There was a problem hiding this comment.
Interesting. So before inpod, drain was the entire process shutting down. Now its not, so it MUST terminate in some bounded time.
Do we want this here, or at the inpod layer?
There was a problem hiding this comment.
Do we want this here, or at the inpod layer?
I'm not sure where else to put it, but in terms of error reporting this seems best - this task is spawned to run to completion, and the inpod layer already initiates the drain and waits for it, the most it can do is drop the drain.
(we could do spawnhandles and aborts and punch this up a layer I guess, but the effect would be the same)
This reverts commit e7a03e3.
howardjohn
approved these changes
Apr 5, 2024
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS handshakes (tokio-rustls) should have a deadline (practically not a big deal for us, but still)
During certain scenarios where workloads are removed, inbound server "graceful shutdown" can deadlock while
awaiting http2 server to finish up, leaving the spawned task to hang indefinitely, so add a deadline to that as a safety measure (still looking into why it does, theshutdownpart ofgraceful_shutdownimplies a guaranteed termination, but deadline seems safer regardless)1.2.0(if this is controversial, can drop it)tokio-consolestuff (don't find it terribly useful, also our logrates @ tracelevel tend to overwhelm it, will keep if someone feels strongly)