Implement outbound drain #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
bleggett
force-pushed
the
bleggett/outbound-drain
branch
from
dd34c38 to
a13ca3b
Compare
howardjohn
approved these changes
Apr 9, 2024
bleggett
force-pushed
the
bleggett/outbound-drain
branch
from
a13ca3b to
ddbd7e1
Compare
|
What we really need beyond this PR is something like a drain_type and more complex drain channels:
This PR is just a stopgap to handle some workload termination corner cases. |
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/outbound-drain
branch
from
ddbd7e1 to
7efba68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #894 - there are some other
spawnsthat we need to guarantee terminate, to avoid stuck tasks.Most of these are in Outbound, which unlike the others never really had per-connection drain.
This adds drains such that all outbound
spawnsare guaranteed to terminate when the workload is drained, this avoids several scenarios where task leaks are possible.What we really need beyond this PR is something like a
drain_typeand more complex drain channels:This PR is just a stopgap to handle some workload termination corner cases.