add get_dataset_version method to catalog and metastore #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
bb2d1fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://583b516e.datachain-documentation.pages.dev |
| Branch Preview URL: | https://add-get-dataset-version.datachain-documentation.pages.dev |
mattseddon
force-pushed
the
add-get-dataset-version
branch
from
4c738ba to
cb63b52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 87.70% 87.75% +0.04%
==========================================
Files 112 112
Lines 10672 10727 +55
Branches 1437 1438 +1
==========================================
+ Hits 9360 9413 +53
- Misses 954 955 +1
- Partials 358 359 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was an attempt to solve an issue with dataset version previews taking too long to load. The theory was that we could cut down the amount of data being requested from the database by only calling for a single version with the dataset.
The main drawback of this approach is the need to add a further 2 dataclasses (one here and one in Studio). As a result, I have decided to go with #642. We can always come back to this if we need further performance improvements.
The required Studio changes can be found at https://github.com/iterative/studio/pull/10997