do not pre-load dataset version preview from string #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
a94eac4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce149a29.datachain-documentation.pages.dev |
| Branch Preview URL: | https://do-not-load-preview.datachain-documentation.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 87.70% 87.73% +0.03%
==========================================
Files 112 112
Lines 10672 10676 +4
Branches 1437 1437
==========================================
+ Hits 9360 9367 +7
+ Misses 954 950 -4
- Partials 358 359 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
force-pushed
the
do-not-load-preview
branch
from
bba502e to
d1d7143
Compare
dreadatour
approved these changes
Nov 29, 2024
src/datachain/dataset.py
Outdated
| @cached_property | ||
| def preview(self) -> Optional[list[dict]]: | ||
| if isinstance(self._preview_data, str): | ||
| return json.loads(self._preview_data) |
There was a problem hiding this comment.
Should we use orjson as it is faster?
See #178
There was a problem hiding this comment.
I did consider but was scared... should be fine 😬
mattseddon
force-pushed
the
do-not-load-preview
branch
from
d1d7143 to
a94eac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we don't load a dataset version's preview to a dict from a string until it has been requested. This should mean that we can continue to use the pattern of loading all version for a dataset via
catalog.get_datasetwithout taking the performance hit of loading all of the dataset version previews viajson.loads