torch-loader(example): use persistent workers to reduce test time #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Dec 12, 2024
| @@ -69,6 +69,7 @@ def forward(self, x): | |||
| ds.to_pytorch(transform=transform), | |||
| batch_size=25, | |||
| num_workers=4, | |||
| persistent_workers=True, | |||
There was a problem hiding this comment.
With persistent_workers set, it takes much less time to run 3 epochs than before (when we ran just a single epoch).
skshetry
commented
Dec 12, 2024
| @@ -81,6 +81,8 @@ def examples(session: nox.Session) -> None: | |||
| session.install(".[examples]") | |||
| session.run( | |||
| "pytest", | |||
| "--durations=0", | |||
There was a problem hiding this comment.
This will be useful to know how much each tests take.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 87.31% 87.34% +0.02%
==========================================
Files 113 113
Lines 10796 10796
Branches 1480 1480
==========================================
+ Hits 9427 9430 +3
+ Misses 991 989 -2
+ Partials 378 377 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skshetry
commented
Dec 12, 2024
Deploying datachain-documentation with
|
| Latest commit: |
b92a9dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1f94822.datachain-documentation.pages.dev |
| Branch Preview URL: | https://torch-persistent-workers.datachain-documentation.pages.dev |
mattseddon
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.