Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch-loader(example): use persistent workers to reduce test time #694

Merged
merged 2 commits into from
Dec 12, 2024
Merged

torch-loader(example): use persistent workers to reduce test time #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a384e
torch-loader(example): use persistent workers to reduce test time
skshetry Dec 12, 2024
b92a9dd
Update examples/get_started/torch-loader.py
skshetry Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/get_started/torch-loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from datachain.torch import label_to_int

STORAGE = "gs://datachain-demo/dogs-and-cats/"
NUM_EPOCHS = os.getenv("NUM_EPOCHS", "3")
NUM_EPOCHS = int(os.getenv("NUM_EPOCHS", "3"))

# Define transformation for data preprocessing
transform = v2.Compose(
Expand Down Expand Up @@ -68,7 +68,8 @@ def forward(self, x):
train_loader = DataLoader(
ds.to_pytorch(transform=transform),
batch_size=25,
num_workers=4,
num_workers=max(4, os.cpu_count() or 2),
persistent_workers=True,
Copy link
Member Author

@skshetry skshetry Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With persistent_workers set, it takes much less time to run 3 epochs than before (when we ran just a single epoch).

multiprocessing_context=multiprocessing.get_context("spawn"),
)

Expand All @@ -77,7 +78,7 @@ def forward(self, x):
optimizer = optim.Adam(model.parameters(), lr=0.001)

# Train the model
for epoch in range(int(NUM_EPOCHS)):
for epoch in range(NUM_EPOCHS):
with tqdm(
train_loader, desc=f"epoch {epoch + 1}/{NUM_EPOCHS}", unit="batch"
) as loader:
Expand Down
2 changes: 2 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ def examples(session: nox.Session) -> None:
session.install(".[examples]")
session.run(
"pytest",
"--durations=0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be useful to know how much each tests take.

"tests/examples",
"-m",
"examples",
*session.posargs,
Expand Down
2 changes: 1 addition & 1 deletion tests/examples/test_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def smoke_test(example: str, env: Optional[dict] = None):
@pytest.mark.get_started
@pytest.mark.parametrize("example", get_started_examples)
def test_get_started_examples(example):
smoke_test(example, {"NUM_EPOCHS": "1"})
smoke_test(example)


@pytest.mark.examples
Expand Down
Loading