-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user-guide: merge/remove duplicate pages from new Installation subsection #701
Comments
Awesome. This would be worked on immediately after #695 is closed? And can we include adding relevant Updating DVC notes here? (See #695 (review).) Or should I open a separate issue? |
@jorgeorpinel I would keep it as a separate ticket. It's not a simple one :) |
OK, moved to #702 |
This comment has been minimized.
This comment has been minimized.
and misc. fixes around this, et al. Addresses a checkbox in #701
Fix #701: Move installation page to the top level of the docs and remove duplicate pages
This one part is not done right. See #701 (comment). It should be re-done by re-applying the changes in 1774355 which were reverted as explained in #695 (review). |
@jorgeorpinel since the PR has been merged you need to create a new with these changes probably? |
@jorgeorpinel The necessary changes have been applied correctly, please check it again. So, let's close this issue (an open another one if needed). |
Yes @shcheklein, a new PR is needed to fix this. I am happy to do this work myself again, but do we agree that undoing other people's work is confusing and unproductive? I could've missed this problem for example, and it would be totally lost. In this particular case, I was asked to review that PR in #695 (comment), then I was asked for help on it in #695 (comment), and then when I contributed to the branch, my work was literally reverted. In fact this may be happening again in #732 (comment) right now... |
Done. This will be closed in 876034b. |
Depends on: #695
Related: #700 , #660
The text was updated successfully, but these errors were encountered: