Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-guide: merge/remove duplicate pages from new Installation subsection #701

Closed
5 tasks done
dashohoxha opened this issue Oct 16, 2019 · 10 comments · Fixed by #734 or #725
Closed
5 tasks done

user-guide: merge/remove duplicate pages from new Installation subsection #701

dashohoxha opened this issue Oct 16, 2019 · 10 comments · Fixed by #734 or #725
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@dashohoxha
Copy link
Contributor

dashohoxha commented Oct 16, 2019

Depends on: #695
Related: #700 , #660

@dashohoxha dashohoxha self-assigned this Oct 16, 2019
@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions get-started p1-important Active priorities to deal within next sprints labels Oct 16, 2019
@shcheklein shcheklein changed the title user-guide: deduplicate pages deduplicate pages after merging the new Install section Oct 16, 2019
@jorgeorpinel jorgeorpinel changed the title deduplicate pages after merging the new Install section user-guide: merge/remove duplicate pages from new Installation subsection Oct 16, 2019
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 16, 2019

Awesome. This would be worked on immediately after #695 is closed?

And can we include adding relevant Updating DVC notes here? (See #695 (review).) Or should I open a separate issue?

@shcheklein
Copy link
Member

@jorgeorpinel I would keep it as a separate ticket. It's not a simple one :)

@jorgeorpinel
Copy link
Contributor

OK, moved to #702

@jorgeorpinel

This comment has been minimized.

jorgeorpinel added a commit that referenced this issue Oct 16, 2019
and misc. fixes around this, et al.

Addresses a checkbox in #701
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 16, 2019

Remove https://dvc.org/doc/user-guide/development...

I'm addressing this in 1774355 as part of the current PR #695.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 25, 2019

Update https://dvc.org/doc/user-guide/development. See details in #700.

This one part is not done right. See #701 (comment). It should be re-done by re-applying the changes in 1774355 which were reverted as explained in #695 (review).

@jorgeorpinel jorgeorpinel reopened this Oct 25, 2019
@shcheklein
Copy link
Member

@jorgeorpinel since the PR has been merged you need to create a new with these changes probably?

@dashohoxha
Copy link
Contributor Author

It should be re-done by re-applying the changes

@jorgeorpinel The necessary changes have been applied correctly, please check it again. So, let's close this issue (an open another one if needed).

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 25, 2019

Yes @shcheklein, a new PR is needed to fix this. I am happy to do this work myself again, but do we agree that undoing other people's work is confusing and unproductive? I could've missed this problem for example, and it would be totally lost.

In this particular case, I was asked to review that PR in #695 (comment), then I was asked for help on it in #695 (comment), and then when I contributed to the branch, my work was literally reverted. In fact this may be happening again in #732 (comment) right now...

@jorgeorpinel
Copy link
Contributor

Done. This will be closed in 876034b.

@iesahin iesahin added the C: guide Content of /doc/user-guide label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
4 participants