Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #701: Move installation page to the top level of the docs and remove duplicate pages #734

Merged
merged 7 commits into from
Oct 25, 2019
Merged

Fix #701: Move installation page to the top level of the docs and remove duplicate pages #734

merged 7 commits into from
Oct 25, 2019

Conversation

dashohoxha
Copy link
Contributor

@dashohoxha dashohoxha commented Oct 24, 2019 •
edited
Loading

Fix: #701, #660

@shcheklein shcheklein temporarily deployed to dvc-org-pr-734 October 24, 2019 12:48 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-pr-734 October 24, 2019 13:05 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-pr-734 October 24, 2019 13:25 Inactive
@dashohoxha dashohoxha changed the title [WIP] Fix #701: Move installation page to the top level of the docs Fix #701: Move installation page to the top level of the docs and remove duplicate pages Oct 24, 2019
@dashohoxha dashohoxha requested a review from shcheklein October 24, 2019 13:27
@dashohoxha dashohoxha mentioned this pull request Oct 25, 2019
Merged
shcheklein
shcheklein requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I'm not sure if it's important enough to keep it at the very top level but we can change this in the future. Please, see a few comments and requests for further simplification.

@dashohoxha
Copy link
Contributor Author

I'm not sure if it's important enough to keep it at the very top level but we can change this in the future.

Since we just link to it from get-started, I think that it should be the first item on the left menu, before Get Started. But it can be fixed later if needed.

@dashohoxha dashohoxha requested a review from shcheklein October 25, 2019 04:23
@shcheklein shcheklein requested a deployment to dvc-org-pr-734 October 25, 2019 04:24 Abandoned
@shcheklein shcheklein merged commit c0df9b2 into master Oct 25, 2019
@shcheklein
Copy link
Member

@dashohoxha yep, agreed, we can def make it go before get started

@dashohoxha dashohoxha deleted the remove-duplicate-install-pages branch October 25, 2019 06:35
This was referenced Oct 25, 2019
Closed
Merged
jorgeorpinel added a commit that referenced this pull request Oct 25, 2019
@jorgeorpinel
get-started: improve introductory initialize instructions
0a61537 
per #734 (review)
@shcheklein
Copy link
Member

@dashohoxha @jorgeorpinel had to revert it back since it affected the way dvc.org/doc (main page) looks like. Before it was using Get Started index as a default one and it was crafted to look nice and it makes sense to start with get started :) Install index page is not ready to be a front page for the docs website. Need more work here.

@jorgeorpinel
Copy link
Contributor

Moving discussion to #747.

@jorgeorpinel jorgeorpinel mentioned this pull request Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel left review comments

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user-guide: merge/remove duplicate pages from new Installation subsection
3 participants
@dashohoxha @shcheklein @jorgeorpinel