-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive: update setup guide for LocalWebserver auth #3655
Conversation
dvc used Pydrive2's `CommandLineAuth` mechanism, which used the now-deprecated OAuth2 out-of-band authorization. This was replaced with `LocalWebserver` authentication, which no longer requires manual setup of client id/secret. iterative/dvc-objects#52
Note that this will have to be merged after iterative/dvc-objects#52 |
@@ -141,22 +139,6 @@ API connections, and its | |||
|
|||
![](/img/gdrive-create-credentials.png) | |||
|
|||
6. The newly generated **client ID** and **client secret** should be shown to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtrifiro I'm not sure I understand why we want to remove this? Creating a custom APP is still better compared to the built -in one. Also, it's not related to the changes we are doing, or I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, this does not make any sense 🤦 Closing this PR as it's not required
> Note that Google Drive API usage limits/quotas apply per _project_ client and | ||
> can be reviewed in the | ||
> [OAuth consent screen](https://console.developers.google.com/apis/credentials/consent). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still applicable?
Maybe we should deprecate this page in favor of the remote blog posts series (e.g.)... We keep having to maintain specific 3rd party docs. |
p.s. that said it does have OK statistics with over 2% of all site traffic (half of this page's, for context) and a low 5% bounce rate. |
Closing this as it is pointless: we still need to setup client id/secret for custom OAuth apps |
dvc used Pydrive2's
CommandLineAuth
mechanism, which used the now-deprecated OAuth2 out-of-band authorization.This was replaced with
LocalWebserver
authentication, which no longer requires manual setup of client id/secret.See iterative/dvc-objects#52 for more context