Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: update setup guide for LocalWebserver auth #3655

Closed
wants to merge 1 commit into from
Closed

gdrive: update setup guide for LocalWebserver auth #3655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions content/docs/user-guide/setup-google-drive-remote.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@ We highly recommend this for heavy use and advanced needs because:

DVC uses the [Google Drive API](https://developers.google.com/drive) to connect
to your Google Drive. This requires a Google Cloud _project_ that allows Drive
API connections, and its
[OAuth](https://developers.google.com/identity/protocols/OAuth2) credentials
(**client ID** and **client secret**).
API connections.

1. Sign into the [Google API Console](https://console.developers.google.com).

Expand Down Expand Up @@ -141,22 +139,6 @@ API connections, and its

![](/img/gdrive-create-credentials.png)

6. The newly generated **client ID** and **client secret** should be shown to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtrifiro I'm not sure I understand why we want to remove this? Creating a custom APP is still better compared to the built -in one. Also, it's not related to the changes we are doing, or I'm missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, this does not make any sense 🤦 Closing this PR as it's not required

you now, and you can always come back to **Credentials** to fetch them.

✅ It should be safe to share **client ID** and **client secret** among your
team. These credentials are only used to generate the
[authorization](#authorization) URL you'll need to visit later in order to
connect to the Google Drive.

Finally, use the `dvc remote modify` command to set the credentials (for each
GDrive remote), for example:

```dvc
$ dvc remote modify myremote gdrive_client_id 'client-id'
$ dvc remote modify myremote gdrive_client_secret 'client-secret'
```

> Note that Google Drive API usage limits/quotas apply per _project_ client and
> can be reviewed in the
> [OAuth consent screen](https://console.developers.google.com/apis/credentials/consent).
Comment on lines 142 to 144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still applicable?

Expand Down