Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc: change ' for ` in dynamic parts of output messages #2644

Merged
merged 4 commits into from
Oct 28, 2019
Merged

dvc: change ' for ` in dynamic parts of output messages #2644

merged 4 commits into from
Oct 28, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Oct 21, 2019 •
edited
Loading

  • Have you followed the guidelines in our
    Contributing document? Yes

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? No

efiop
efiop reviewed Oct 21, 2019
View reviewed changes
dvc/stage.py Outdated Show resolved Hide resolved
@jorgeorpinel

This comment has been minimized.

Sign in to view
@efiop
Copy link
Contributor

efiop commented Oct 22, 2019

@jorgeorpinel Let's not change ' to `. In code itself, we are using ' to mark dynamic parts of the printed message. ` is used mostly in the comments, which doesn't matter that much.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 22, 2019 •
edited
Loading

OK sure! But I do see ` used for dynamic parts of the printed message. Can I change those to ' ?

@jorgeorpinel
Copy link
Contributor Author

Can I change those to ' ?

I rewrote my master branch with these changes among other small updates. Will add a couple comments...

jorgeorpinel
jorgeorpinel commented Oct 22, 2019
View reviewed changes
dvc/command/imp_url.py Outdated Show resolved Hide resolved
jorgeorpinel
jorgeorpinel commented Oct 22, 2019
View reviewed changes
dvc/scm/git/__init__.py Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel changed the title stage: change ' for ` in output for consistency dvc: change ` for ' in dynamic parts of output messages Oct 22, 2019
efiop
efiop reviewed Oct 23, 2019
View reviewed changes
dvc/command/get_url.py Outdated Show resolved Hide resolved
efiop
efiop reviewed Oct 28, 2019
View reviewed changes
dvc/stage.py Show resolved Hide resolved
efiop
efiop suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Only one minor comment left.

@efiop efiop merged commit a48481b into iterative:master Oct 28, 2019
@dependabot-preview dependabot-preview bot mentioned this pull request Oct 30, 2019
Merged
@weekly-digest weekly-digest bot mentioned this pull request Nov 4, 2019
Closed
This was referenced Nov 14, 2019
Merged
Closed
@jorgeorpinel jorgeorpinel changed the title dvc: change ` for ' in dynamic parts of output messages dvc: change ' for ` in dynamic parts of output messages Dec 19, 2019
@jorgeorpinel jorgeorpinel mentioned this pull request Dec 19, 2019
Merged
3 tasks
@skshetry skshetry mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop requested changes

@dashohoxha dashohoxha dashohoxha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @efiop @dashohoxha