Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2680 and Simple typo rectified #2715

Merged
merged 2 commits into from
Nov 3, 2019
Merged

Conversation

ATR-oCiTy
Copy link
Contributor

@ATR-oCiTy ATR-oCiTy commented Nov 3, 2019

dvc/remote/s3.py : Rectified simple typo
dvc/updater.py : Removed "Cask 'dvc' is not installed." error

dvc/remote/s3.py:L148: transfered -> transferred
Deleted https://github.com/iterative/dvc/blob/0.66.3/dvc/updater.py#L126 and code block https://github.com/iterative/dvc/blob/0.66.3/dvc/updater.py#L173

Fixes #2680

@@ -169,14 +168,6 @@ def _get_darwin(self):
return "formula"
else:
return "pip"

# NOTE: both pkg and cask put dvc binary into /usr/local/bin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot for fixing this!

@ATR-oCiTy ATR-oCiTy changed the title Simple typos mectified Fixed issue #2680 and Simple typo rectified Nov 3, 2019
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@efiop efiop merged commit 1b54c7f into iterative:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install: "Cask 'dvc' is not installed." error
2 participants