Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2680 and Simple typo rectified #2715

Merged
merged 2 commits into from
Nov 3, 2019
Merged

Fixed issue #2680 and Simple typo rectified #2715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e26517e
Simple typos mectified
ATR-oCiTy Nov 3, 2019
2c0b209
Rectified install: Cask 'dvc' is not installed. error #2680
ATR-oCiTy Nov 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dvc/remote/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def _copy(cls, s3, from_info, to_info, extra_args):
# multipart.
#
# If an object's etag looks like '8978c98bb5a48c2fb5f2c4c905768afa',
# then it was transfered as a single part, which means that the chunk
# then it was transferred as a single part, which means that the chunk
# size used to transfer it was greater or equal to the ContentLength
# of that object. So to preserve that tag over the next transfer, we
# could use any value >= ContentLength.
Expand Down
9 changes: 0 additions & 9 deletions dvc/updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ def _get_update_instructions(self):
"yum": "Run {yellow}yum{reset} update dvc",
"yay": "Run {yellow}yay{reset} {blue}-S{reset} dvc",
"formula": "Run {yellow}brew{reset} upgrade dvc",
"cask": "Run {yellow}brew cask{reset} upgrade dvc",
"apt": (
"Run {yellow}apt-get{reset} install"
" {blue}--only-upgrade{reset} dvc"
Expand Down Expand Up @@ -169,14 +168,6 @@ def _get_darwin(self):
return "formula"
else:
return "pip"

# NOTE: both pkg and cask put dvc binary into /usr/local/bin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot for fixing this!

# so in order to know which method of installation was used,
# we need to actually call `brew cask`
ret = os.system("brew cask ls dvc")
if ret == 0:
return "cask"

return None

def _get_windows(self):
Expand Down