-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import-url: support directories #2894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @verasativa ! 🎉 Please see a few minor comments up above.
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
@verasativa One more thing. Let's add a simple test for this. Take a look at tests/unit/remote/test_remote_dir.py , where we have all of the related code. The test would look something like:
|
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
tests/unit/remote/test_remote_dir.py
Outdated
@@ -1,5 +1,6 @@ | |||
# -*- coding: utf-8 -*- | |||
import pytest | |||
import os | |||
|
|||
from dvc.remote.s3 import RemoteS3 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why tests are failing 🙂
from dvc.utils import walk_files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@verasativa Looks great! Just one more minor comment up above and I think we will be done.
Ok, LGTM after @efiop suggestions are resolved |
For the record: 1 windows test failed because of temporary issues with chocolatey, that are unrelated to this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! 🎉
For the record: no need to adjust docs, as they already say that we support files and dirs. EDIT: actually we do need to adjust them, see linked issue below. |
No description provided.