-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import-url: add directories to examples #2907
Conversation
For the record: windows test failing because of unrelated issues with chocolatey. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check this box if this PR does not require documentation updates...
Why is this checked? :P Perhaps I haven't noticed the PR on dvc.org? Otherwise, I also approve these changes.
@jorgeorpinel bc |
You conveniently omit
@shcheklein π OK, found it: iterative/dvc.org/issues/841 |
@jorgeorpinel only bc it's referenced and is visible here already: |
That is a link from the issue back to this PR. I think we mean a link to the issue in this PR? (In the description of the PR in fact.) Would be much more visible I think. I mean, there's many of these automated thingies in PRs and I doubt people always pay attention to them. E.g.: Just trying to understand the meaning of that sentence in the PULL_REQUEST template. |
p.s. Obviously this is no longer relevant in this case but (and I was mostly messing around) but it's an interesting question for future reference actually. |
@jorgeorpinel Will try to place it explicitly, thanks for the heads up. π |
Yeah, I think 95% of the job and value is to have the proper ticket created. I agree though that an explicit link in the PR/issue is better and improves readability. For me it was usually fine to see a connected issue in the PR - it serves both ways anyway. |
Thanks guys! Sorry to seem so strict, wasn't the intention originally π¬ obviously some times these small things slip and its totally fine. |
#2894
β Have you followed the guidelines in the Contributing to DVC list?
π Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
β Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. π