-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analytics: introduce DVC_NO_ANALYTICS #6453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
requested review from
isidentical and
skshetry
and removed request for
isidentical
August 17, 2021 11:10
efiop
changed the title
analytics: introduce DVC_NO_ANALYTICS
[WIP] analytics: introduce DVC_NO_ANALYTICS
Aug 17, 2021
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Aug 17, 2021
efiop
changed the title
[WIP] analytics: introduce DVC_NO_ANALYTICS
analytics: introduce DVC_NO_ANALYTICS
Aug 17, 2021
pared
approved these changes
Aug 17, 2021
skshetry
reviewed
Aug 17, 2021
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Aug 17, 2021
Replacing DVC_ANALYTICS. This is following our other env conventions and will not have effect if set to false/no/etc, and will only work if set to true/yes/y/etc. Will disable analytics even if it is explicitly enabled in our configs. Kudos @skshetry
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Aug 17, 2021
efiop
added a commit
to iterative/dvc.org
that referenced
this pull request
Aug 17, 2021
skshetry
approved these changes
Aug 17, 2021
jorgeorpinel
added a commit
to iterative/dvc.org
that referenced
this pull request
Aug 18, 2021
* docs: analytics: add DVC_NO_ANALYTICS mention Per iterative/dvc#6453 * Update content/docs/user-guide/analytics.md * Update content/docs/user-guide/analytics.md Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing DVC_ANALYTICS. This is following our other env conventions and
will not have effect if set to false/no/etc, and will only work if set
to true/yes/y/etc. Will disable analytics even if it is explicitly
enabled in our configs.
Per discussion in iterative/dvc.org#2724 . Kudos @skshetry