Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics: introduce DVC_NO_ANALYTICS #6453

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Aug 17, 2021

Replacing DVC_ANALYTICS. This is following our other env conventions and
will not have effect if set to false/no/etc, and will only work if set
to true/yes/y/etc. Will disable analytics even if it is explicitly
enabled in our configs.

Per discussion in iterative/dvc.org#2724 . Kudos @skshetry

@efiop efiop requested a review from a team as a code owner August 17, 2021 11:10
@efiop efiop requested review from isidentical and skshetry and removed request for isidentical August 17, 2021 11:10
@efiop efiop changed the title analytics: introduce DVC_NO_ANALYTICS [WIP] analytics: introduce DVC_NO_ANALYTICS Aug 17, 2021
efiop added a commit to iterative/dvc.org that referenced this pull request Aug 17, 2021
@efiop efiop changed the title [WIP] analytics: introduce DVC_NO_ANALYTICS analytics: introduce DVC_NO_ANALYTICS Aug 17, 2021
dvc/analytics.py Outdated Show resolved Hide resolved
efiop added a commit to iterative/dvc.org that referenced this pull request Aug 17, 2021
Replacing DVC_ANALYTICS. This is following our other env conventions and
will not have effect if set to false/no/etc, and will only work if set
to true/yes/y/etc. Will disable analytics even if it is explicitly
enabled in our configs.

Kudos @skshetry
@efiop efiop requested a review from skshetry August 17, 2021 11:41
efiop added a commit to iterative/dvc.org that referenced this pull request Aug 17, 2021
efiop added a commit to iterative/dvc.org that referenced this pull request Aug 17, 2021
@efiop efiop merged commit 33c6a9b into iterative:master Aug 17, 2021
@efiop efiop deleted the analytics-env branch August 17, 2021 12:17
@efiop efiop added the feature is a feature label Aug 17, 2021
jorgeorpinel added a commit to iterative/dvc.org that referenced this pull request Aug 18, 2021
* docs: analytics: add DVC_NO_ANALYTICS mention

Per iterative/dvc#6453

* Update content/docs/user-guide/analytics.md

* Update content/docs/user-guide/analytics.md

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants