Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newly added DVC_ANALYTICS environment variable #721

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 16, 2021

This PR takes advantage of the new environment variable added to DVC this morning.

Demo / Comparison of performance:

Previous (old demo from #699):

Screen.Recording.2021-07-31.at.11.41.55.am.mov

Now (performance is the same for analytics turned on and off):

Screen.Recording.2021-08-17.at.9.28.34.am.mov

Relates to #608

@mattseddon mattseddon added the product PR that affects product label Aug 16, 2021
@mattseddon mattseddon self-assigned this Aug 16, 2021
@codeclimate
Copy link

codeclimate bot commented Aug 16, 2021

Code Climate has analyzed commit 965833a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon marked this pull request as ready for review August 16, 2021 23:34
@mattseddon mattseddon merged commit a533bb4 into master Aug 17, 2021
@mattseddon mattseddon deleted the use-new-analytics-variable branch August 17, 2021 03:43
@skshetry
Copy link
Member

skshetry commented Aug 17, 2021

This has been changed to DVC_NO_ANALYTICS in the newest release. You can set it to any value you want to.

See iterative/dvc#6453 and iterative/dvc.org#2724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants