Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a basic README #111

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Write a basic README #111

merged 1 commit into from
Nov 9, 2022

Conversation

rogermparent
Copy link
Contributor

@rogermparent rogermparent commented Nov 9, 2022

This basic README is written in anticipation of open-sourcing this repo. IMO we don't need anything fancy, especially with the project's APIs being so heavily in flux. For example, #33 will remove most of the PostCSS options mentioned here, as well as a lot of layout wrapper stuff that will greatly simplify and change how the theme is consumed.

@rogermparent rogermparent self-assigned this Nov 9, 2022
@rogermparent rogermparent requested a review from a team November 9, 2022 01:57
Copy link
Contributor

@yathomasi yathomasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we can create a major to-do list for us as well as others to know. One is we want everything documented in our example docs. I started documenting the features I added later https://gatsby-theme-iterative-example.herokuapp.com/doc/examples.

I am approving so that we can have this repo made public asap. We can always improve more on follow-up.

Comment on lines +4 to +6
[Iterative](https://iterative.ai). This package is currently purpose-built
specifically for our websites and not very useful outside of them, but we intend
to change that as we make improvements and iron out issues!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clear our main purpose here of providing a reusable package for easily creating documentation, sharing reusable components, utility functions, etc. This will clear our goal as well. We can write a disclaimer as well.

Comment on lines +42 to +45
### Examples

See this example from
[the example website's `gatsby-config.js`](https://github.com/iterative/gatsby-theme-iterative/blob/main/packages/example/gatsby-config.js).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think example usage should include installation

yarn add @dvcorg/gatsby-theme-iterative

and using the theme as a package itself once we make this public we expect others to try it out as a package.

@rogermparent
Copy link
Contributor Author

Great points, and thanks for the quick approval! This was very much just a last minute "get the minimum to go public asap" up without regard to any way a consumer could use them, considering I doubt anyone but us will for a while. I'll get to work on a follow-up tomorrow amending with your suggestions.

@rogermparent rogermparent merged commit 24e4797 into main Nov 9, 2022
@rogermparent rogermparent deleted the create-readme branch November 9, 2022 05:19
@rogermparent
Copy link
Contributor Author

I wonder why the deploy didn't link up to this PR? One was made on Heroku, but it's only accessible via the UI. We'll have to keep this in mind in case it happens again in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants