-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and simplify styles and templates #33
Conversation
…to replace-postcss-with-tailwind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far. I think we are almost ready to merge this. There seems to be a small padding issue on the mobile view:
- https://gatsby-theme-replace-po-cudk5d.herokuapp.com/doc/start
(seems to have larger padding shrinking the content) - https://dvc.org/doc/start
I think, we can either have the padding removed on mobile view or use max-width
method similar to dvc.org
right now.
I just pushed up a fix to the padding, I had replaced a media query that removed horizontal padding on the content in mobile view without making the tailwind rules that replace it do the same, and the change was subtle enough that I didn't pick it up looking back at it. Thanks again for the great reviews @yathomasi! Sorry there's been so much back-and-forth, I definitely got lost in this PR after a while. I fixed the padding by simply removing px on content on screens below Taking a tangent on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked thoroughly and everything looks good to me. Finally, we should go ahead and merge this.
Also, I think we should bump a minor version with all these changes.
xxsMax: { max: '376px' }, | ||
xsMax: { max: '572px' }, | ||
smMax: { max: '768px' }, | ||
mdMax: { max: '1004px' }, | ||
xs: '572px', | ||
lg: '1005px', | ||
xl: '1200px' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mentioned it earlier too that it would be easier/better if we could use the default values for screen sizes that tailwind uses. But, it's not a blocker as we can continue using the existing tailwind config on consumer websites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! we can follow up after. I decided to port the defaults early on in the process in case anything precise would be broken otherwise.
Bumping to v0.2.0 and merging! Thanks for doing the quick edit to speed this along. |
This reverts commit 2bb4003.
This PR has three main goals:
This could have been broken up into more distinct steps, but ultimately seemed like it would be more work to put in the effort to get one part working only to immediately follow up with removing the part we were adapting to- thus, this monster of a PR.
This PR also makes the homepage look a bit better.
One integrated into the respective repos, this PR's changes should fix quite a few issues: