-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates #4
base: main
Are you sure you want to change the base?
Conversation
02a2910
to
cdcd1c2
Compare
ffd0b5b
to
34e5a2c
Compare
4d0829a
to
b973927
Compare
e997687
to
6201c51
Compare
@yathomasi PTAL - doing some house keeping on iterative's example repos. Though it looks like there's a problem with the dvc data sources for this one. |
Yeah, I also got the following error on
cc: @iterative/dvc |
|
||
dvc get https://github.com/iterative/dataset-registry/ dvc-course/hymenoptera_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this line is supposed to do as the downloaded folder is not used by the pipeline in dvc.yaml
?
|
||
dvc get https://github.com/iterative/dataset-registry/ dvc-course/hymenoptera_data | ||
dvc pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to run dvc pull
you need to provide credentials for the DVC remote defined in https://github.com/iterative/stale-model-example/blob/main/.dvc/config .
I have no idea who has access to those buckets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this workflow has ever run successfully as it is impossible for DVC to access the data given the current and previous setup
There's no credentials configured for the default gcs remote. stale-model-example/.dvc/config Lines 5 to 6 in 4597725
can you double check that this bucket is actually publically accessible and that it's configured to allow public (anonymous) users to have the required permissions? |
.github/workflows/cml.yaml
Outdated
fetch-depth: 0 | ||
- name: Fix git safe.directory in container | ||
run: | | ||
git config --global --add safe.directory ${GITHUB_WORKSPACE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required because of dvc get
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's required for dvc exp run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed for dvc repro
too? Can't find any mention of this requirement in https://dvc.org/doc. Asking because we may need to update/fix https://github.com/iterative/cml_dvc_case/blob/master/.github/workflows/cml.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For dvc repro
normally the answer is no, but if the user's pipeline is doing things with the local git repo (like pipeline stages that run dvc get
) then it may be needed
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
@tasdomas closed by accident? |
@casperdcl I think this repo needs to be archived altogether. |
/CC @jendefig ^ |
Thanks @casperdcl @tasdomas! @RCdeWit had put an admonition on the blog post. But it seems that this may be too broken to keep up, especially since the blog post starts from the repo. Looks like will need to pull this down and put it into the Content Creation Dashboard for an eventual redo. |
Import scikit-learn directly.
Use updated cml cli.