Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #4

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Minor updates #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22f969d
Import scikit-learn directly.
tasdomas Sep 28, 2022
cdcd1c2
Use updated cml cli.
tasdomas Sep 28, 2022
577975f
Fix git safe.directory and configure git user.
tasdomas Oct 10, 2022
0ba390e
Update .github/workflows/cml.yaml
tasdomas Oct 18, 2022
3082647
use `cml ci`
casperdcl Nov 7, 2022
217802a
cml ci explanation
casperdcl Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/cml.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,23 @@ jobs:
runs-on: [ubuntu-latest]
container: docker://dvcorg/cml:0-dvc2-base1
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0
- name: Fix git safe.directory, user name & email
run: |
cml ci
- name: Generate metrics report
env:
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
pip install -r requirements.txt

dvc get https://github.com/iterative/dataset-registry/ dvc-course/hymenoptera_data

dvc get https://github.com/iterative/dataset-registry/ dvc-course/hymenoptera_data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this line is supposed to do as the downloaded folder is not used by the pipeline in dvc.yaml?

dvc pull
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to run dvc pull you need to provide credentials for the DVC remote defined in https://github.com/iterative/stale-model-example/blob/main/.dvc/config .

I have no idea who has access to those buckets

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this workflow has ever run successfully as it is impossible for DVC to access the data given the current and previous setup

dvc exp run

dvc metrics show --show-md >> report.md

cml send-comment report.md
cml comment create --pr report.md
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ evidently
matplotlib
numpy
pandas
sklearn
scikit-learn
torch
torchvision