-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing queued experiments #1392
Comments
It should give users the ability to queue an experiment using an existing experiment as a base. They will be given the choice to select which parameters they want to vary and will then be given the original param value to work from for each of those parameters. LMK if that doesn't make sense. Got any suggestions for a better name? |
Okay, I get it now, thanks. It's from #1120 (comment).
Ideas:
Not sure any of those are great, but I think the main focus should be on setting parameters rather than on queuing or on using existing experiments. Feedback on that feature now that I understand it better:
|
@dberenbaum I addressed your last comment in #1456 Thought it would be best to add some comments/reasoning here:
I went with
This is the "native" experience. I am also not a massive fan but this is what is expected from VS Code extensions (and there are way more complicated flows out there). If we get a lot of complaints then I would consider changing it but I feel it is good enough for now.
I have altered a couple of the quick pick titles to try and make the flow more explicit. The user will now experience this:
Shown on the screen: Screen.Recording.2022-03-17.at.1.46.20.pm.mov |
That all looks good! It seems more straightforward, but I'm biased now that I've spent a lot of time looking at the feature. My biggest fear for this feature is spending time on a feature that might not get used that much, so IMO you definitely shouldn't spend more time on it at this point. |
Thanks, @dberenbaum.
We should be able to tell from the analytics whether or not it is used and we'll also be able to iterate on things as the mechanics of queueing changes. Will close this now. Thanks again for your feedback. |
There are some features I'd like when working with queued experiments:
dvc exp remove [queued_experiment_hash]
).dvc exp remove --queue
).Also, I'm unclear what
DVC: Queue Experiment from Existing
does.The text was updated successfully, but these errors were encountered: