Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove experiment queue command #1453

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add remove experiment queue command #1453

merged 2 commits into from
Mar 17, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 16, 2022

1/2 main <- this <- #1454

Addresses second point of #1392 OP: "Clearing the entire experiment queue (dvc exp remove --queue)."

Demo

Screen.Recording.2022-03-17.at.9.19.13.am.mov
Screen.Recording.2022-03-17.at.9.34.59.am.mov

@mattseddon mattseddon added the product PR that affects product label Mar 16, 2022
@mattseddon mattseddon self-assigned this Mar 16, 2022
@mattseddon mattseddon marked this pull request as ready for review March 16, 2022 22:35
@@ -30,6 +30,7 @@
"command.queueExperimentFromExisting": "Queue Experiment From Existing",
"command.queueExperiment": "Queue Experiment",
"command.removeExperiment": "Remove Experiment",
"command.removeExperimentQueue": "Remove Experiment Queue",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Remove All Queued Experiments" or "Remove Queued Experiments" reads a little better to me, though it's not too ambiguous as-is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to be Remove All Queued Experiments because Remove Queued Experiment is coming next and we use All as a determiner in other user-facing commands.

@codeclimate
Copy link

codeclimate bot commented Mar 17, 2022

Code Climate has analyzed commit 45c4c7c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.2% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit c3868f3 into main Mar 17, 2022
@mattseddon mattseddon deleted the remove-queued branch March 17, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants