Add remove queued experiment command #1454
Conversation
|
I don't know if it's planned, but at another stage, but maybe also adding an action on the queued experiment in the tree to remove it would be a little more intuitive? Something like the "X" in the sorts and filters maybe? |
mattseddon
force-pushed
the
remove-queued-exp
branch
from
13713a1 to
20aad91
Compare
I'm not sure if we have a ticket for the tree but we should be able to do this action (and more) from both the tree and the table. It is a destructive action so we will need to be careful and potentially add a warning modal across the board. I will look for a ticket and add one if I cannot find one. |
|
Code Climate has analyzed commit 20aad91 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
2/2
main<- #1453 <- thisThis PR addresses the first point of #1392 OP: "Removal of an experiment from the queue (dvc exp remove [queued_experiment_hash])."
From speaking to Dave about whether or not this should have been a separate command or included with the existing exp remove command:
"queuing is in the middle of big changes. Right now, it makes some sense to keep them together since the same command removes them in the CLI. But we are moving to separate them more, so ultimately it might be better to not view them as just another experiment."
I did try both ways and having them split out did feel more intuitive.
Demo
Screen.Recording.2022-03-17.at.12.31.03.pm.mov
Note: When removing a queued experiment the only file path that is hit is
/vscode-dvc/.git/logs/refs/exps/stashI have updated the experiment file system watcher to cater for this.